Skip to content

Commit 1a35eec

Browse files
committed
Remove mentions of ./x suggest and suggest-tests in rustc-dev-guide
1 parent e181c52 commit 1a35eec

File tree

4 files changed

+0
-80
lines changed

4 files changed

+0
-80
lines changed

src/doc/rustc-dev-guide/src/SUMMARY.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@
3535
- [Cranelift codegen backend](./tests/codegen-backend-tests/cg_clif.md)
3636
- [GCC codegen backend](./tests/codegen-backend-tests/cg_gcc.md)
3737
- [Performance testing](./tests/perf.md)
38-
- [Suggest tests tool](./tests/suggest-tests.md)
3938
- [Misc info](./tests/misc.md)
4039
- [Debugging the compiler](./compiler-debugging.md)
4140
- [Using the tracing/logging instrumentation](./tracing.md)

src/doc/rustc-dev-guide/src/building/quickstart.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,6 @@ and check the output.
6161
Use `--bless` if you've made a change and want to update the `.stderr` files
6262
with the new output.
6363

64-
> `./x suggest` can also be helpful for suggesting which tests to run after a
65-
> change.
66-
6764
Congrats, you are now ready to make a change to the compiler! If you have more
6865
questions, [the full chapter](./how-to-build-and-run.md) might contain the
6966
answers, and if it doesn't, feel free to ask for help on

src/doc/rustc-dev-guide/src/building/suggested.md

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -270,23 +270,6 @@ run the tests at some later time. You can then use `git bisect` to track down
270270
is that you are left with a fairly fine-grained set of commits at the end, all
271271
of which build and pass tests. This often helps reviewing.
272272

273-
## `x suggest`
274-
275-
The `x suggest` subcommand suggests (and runs) a subset of the extensive
276-
`rust-lang/rust` tests based on files you have changed. This is especially
277-
useful for new contributors who have not mastered the arcane `x` flags yet and
278-
more experienced contributors as a shorthand for reducing mental effort. In all
279-
cases it is useful not to run the full tests (which can take on the order of
280-
tens of minutes) and just run a subset which are relevant to your changes. For
281-
example, running `tidy` and `linkchecker` is useful when editing Markdown files,
282-
whereas UI tests are much less likely to be helpful. While `x suggest` is a
283-
useful tool, it does not guarantee perfect coverage (just as PR CI isn't a
284-
substitute for bors). See the [dedicated chapter](../tests/suggest-tests.md) for
285-
more information and contribution instructions.
286-
287-
Please note that `x suggest` is in a beta state currently and the tests that it
288-
will suggest are limited.
289-
290273
## Configuring `rustup` to use nightly
291274

292275
Some parts of the bootstrap process uses pinned, nightly versions of tools like

src/doc/rustc-dev-guide/src/tests/suggest-tests.md

Lines changed: 0 additions & 59 deletions
This file was deleted.

0 commit comments

Comments
 (0)