minor: Use 'deferred task' terminology consistently #21157
+29
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
lnicola
approved these changes
Nov 29, 2025
lnicola
changed the title
davidbarsky
reviewed
Nov 29, 2025
| pub(crate) struct TaskQueue { | ||
| pub(crate) sender: crossbeam_channel::Sender<QueuedTask>, | ||
| pub(crate) receiver: crossbeam_channel::Receiver<QueuedTask>, | ||
| /// `DeferredTaskQueue` holds deferred tasks. These are tasks that |
Contributor
There was a problem hiding this comment.
one small nit: i'd keep the first line of the doc comment on a separate line that summarizes what this is.
after a new, empty line, add a paragraph describing what's happening.
Wilfred
force-pushed
the
task_queue_naming
branch
from
07b2361 to
77ed60c
Compare
Wilfred
force-pushed
the
task_queue_naming
branch
from
77ed60c to
3f74f22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously there was a mix of 'queued task' and 'deferred task' terminology. The deferred terminology is more helpful (it provides a hint of which tasks belong there), so standardise on that term.