Skip to content

Commit c6ae7b3

Browse files
committed
chore: rename unmerge_use to unmerge_imports
Signed-off-by: Prajwal S N <[email protected]>
1 parent bb49364 commit c6ae7b3

File tree

3 files changed

+44
-44
lines changed

3 files changed

+44
-44
lines changed

crates/ide-assists/src/handlers/unmerge_use.rs renamed to crates/ide-assists/src/handlers/unmerge_imports.rs

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ use crate::{
1212
assist_context::{AssistContext, Assists},
1313
};
1414

15-
// Assist: unmerge_use
15+
// Assist: unmerge_imports
1616
//
17-
// Extracts single use item from use list.
17+
// Extracts a use item from a use list into a standalone use list.
1818
//
1919
// ```
2020
// use std::fmt::{Debug, Display$0};
@@ -24,12 +24,12 @@ use crate::{
2424
// use std::fmt::{Debug};
2525
// use std::fmt::Display;
2626
// ```
27-
pub(crate) fn unmerge_use(acc: &mut Assists, ctx: &AssistContext<'_>) -> Option<()> {
27+
pub(crate) fn unmerge_imports(acc: &mut Assists, ctx: &AssistContext<'_>) -> Option<()> {
2828
let tree = ctx.find_node_at_offset::<ast::UseTree>()?;
2929

3030
let tree_list = tree.syntax().parent().and_then(ast::UseTreeList::cast)?;
3131
if tree_list.use_trees().count() < 2 {
32-
cov_mark::hit!(skip_single_use_item);
32+
cov_mark::hit!(skip_single_import);
3333
return None;
3434
}
3535

@@ -43,7 +43,7 @@ pub(crate) fn unmerge_use(acc: &mut Assists, ctx: &AssistContext<'_>) -> Option<
4343
};
4444

4545
let target = tree.syntax().text_range();
46-
acc.add(AssistId::refactor_rewrite("unmerge_use"), label, target, |builder| {
46+
acc.add(AssistId::refactor_rewrite("unmerge_imports"), label, target, |builder| {
4747
let make = SyntaxFactory::with_mappings();
4848
let new_use = make.use_(
4949
use_.visibility(),
@@ -94,22 +94,22 @@ mod tests {
9494
use super::*;
9595

9696
#[test]
97-
fn skip_single_use_item() {
98-
cov_mark::check!(skip_single_use_item);
97+
fn skip_single_import() {
98+
cov_mark::check!(skip_single_import);
9999
check_assist_not_applicable(
100-
unmerge_use,
100+
unmerge_imports,
101101
r"
102102
use std::fmt::Debug$0;
103103
",
104104
);
105105
check_assist_not_applicable(
106-
unmerge_use,
106+
unmerge_imports,
107107
r"
108108
use std::fmt::{Debug$0};
109109
",
110110
);
111111
check_assist_not_applicable(
112-
unmerge_use,
112+
unmerge_imports,
113113
r"
114114
use std::fmt::Debug as Dbg$0;
115115
",
@@ -119,17 +119,17 @@ use std::fmt::Debug as Dbg$0;
119119
#[test]
120120
fn skip_single_glob_import() {
121121
check_assist_not_applicable(
122-
unmerge_use,
122+
unmerge_imports,
123123
r"
124124
use std::fmt::*$0;
125125
",
126126
);
127127
}
128128

129129
#[test]
130-
fn unmerge_use_item() {
130+
fn unmerge_import() {
131131
check_assist(
132-
unmerge_use,
132+
unmerge_imports,
133133
r"
134134
use std::fmt::{Debug, Display$0};
135135
",
@@ -140,7 +140,7 @@ use std::fmt::Display;
140140
);
141141

142142
check_assist(
143-
unmerge_use,
143+
unmerge_imports,
144144
r"
145145
use std::fmt::{Debug, format$0, Display};
146146
",
@@ -154,7 +154,7 @@ use std::fmt::format;
154154
#[test]
155155
fn unmerge_glob_import() {
156156
check_assist(
157-
unmerge_use,
157+
unmerge_imports,
158158
r"
159159
use std::fmt::{*$0, Display};
160160
",
@@ -166,9 +166,9 @@ use std::fmt::*;
166166
}
167167

168168
#[test]
169-
fn unmerge_renamed_use_item() {
169+
fn unmerge_renamed_import() {
170170
check_assist(
171-
unmerge_use,
171+
unmerge_imports,
172172
r"
173173
use std::fmt::{Debug, Display as Disp$0};
174174
",
@@ -180,9 +180,9 @@ use std::fmt::Display as Disp;
180180
}
181181

182182
#[test]
183-
fn unmerge_indented_use_item() {
183+
fn unmerge_indented_import() {
184184
check_assist(
185-
unmerge_use,
185+
unmerge_imports,
186186
r"
187187
mod format {
188188
use std::fmt::{Debug, Display$0 as Disp, format};
@@ -198,9 +198,9 @@ mod format {
198198
}
199199

200200
#[test]
201-
fn unmerge_nested_use_item() {
201+
fn unmerge_nested_import() {
202202
check_assist(
203-
unmerge_use,
203+
unmerge_imports,
204204
r"
205205
use foo::bar::{baz::{qux$0, foobar}, barbaz};
206206
",
@@ -210,7 +210,7 @@ use foo::bar::baz::qux;
210210
",
211211
);
212212
check_assist(
213-
unmerge_use,
213+
unmerge_imports,
214214
r"
215215
use foo::bar::{baz$0::{qux, foobar}, barbaz};
216216
",
@@ -222,9 +222,9 @@ use foo::bar::baz::{qux, foobar};
222222
}
223223

224224
#[test]
225-
fn unmerge_use_item_with_visibility() {
225+
fn unmerge_import_with_visibility() {
226226
check_assist(
227-
unmerge_use,
227+
unmerge_imports,
228228
r"
229229
pub use std::fmt::{Debug, Display$0};
230230
",
@@ -236,19 +236,19 @@ pub use std::fmt::Display;
236236
}
237237

238238
#[test]
239-
fn unmerge_use_item_on_self() {
239+
fn unmerge_import_on_self() {
240240
check_assist(
241-
unmerge_use,
241+
unmerge_imports,
242242
r"use std::process::{Command, self$0};",
243243
r"use std::process::{Command};
244244
use std::process;",
245245
);
246246
}
247247

248248
#[test]
249-
fn unmerge_use_item_with_attributes() {
249+
fn unmerge_import_with_attributes() {
250250
check_assist(
251-
unmerge_use,
251+
unmerge_imports,
252252
r"
253253
#[allow(deprecated)]
254254
use foo::{bar, baz$0};",

crates/ide-assists/src/lib.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -222,8 +222,8 @@ mod handlers {
222222
mod toggle_async_sugar;
223223
mod toggle_ignore;
224224
mod toggle_macro_delimiter;
225+
mod unmerge_imports;
225226
mod unmerge_match_arm;
226-
mod unmerge_use;
227227
mod unnecessary_async;
228228
mod unqualify_method_call;
229229
mod unwrap_block;
@@ -363,7 +363,7 @@ mod handlers {
363363
toggle_ignore::toggle_ignore,
364364
toggle_macro_delimiter::toggle_macro_delimiter,
365365
unmerge_match_arm::unmerge_match_arm,
366-
unmerge_use::unmerge_use,
366+
unmerge_imports::unmerge_imports,
367367
unnecessary_async::unnecessary_async,
368368
unqualify_method_call::unqualify_method_call,
369369
unwrap_block::unwrap_block,

crates/ide-assists/src/tests/generated.rs

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3339,6 +3339,20 @@ sth!{ }
33393339
)
33403340
}
33413341

3342+
#[test]
3343+
fn doctest_unmerge_imports() {
3344+
check_doc_test(
3345+
"unmerge_imports",
3346+
r#####"
3347+
use std::fmt::{Debug, Display$0};
3348+
"#####,
3349+
r#####"
3350+
use std::fmt::{Debug};
3351+
use std::fmt::Display;
3352+
"#####,
3353+
)
3354+
}
3355+
33423356
#[test]
33433357
fn doctest_unmerge_match_arm() {
33443358
check_doc_test(
@@ -3365,20 +3379,6 @@ fn handle(action: Action) {
33653379
)
33663380
}
33673381

3368-
#[test]
3369-
fn doctest_unmerge_use() {
3370-
check_doc_test(
3371-
"unmerge_use",
3372-
r#####"
3373-
use std::fmt::{Debug, Display$0};
3374-
"#####,
3375-
r#####"
3376-
use std::fmt::{Debug};
3377-
use std::fmt::Display;
3378-
"#####,
3379-
)
3380-
}
3381-
33823382
#[test]
33833383
fn doctest_unnecessary_async() {
33843384
check_doc_test(

0 commit comments

Comments
 (0)