Skip to content

Conversation

@tgross35
Copy link
Contributor

We need a bit more flexibility in the formatting, which would be
difficult to achieve with bash. Rewrite the style check to a python
script that will be easier to extend. This is also faster than using
inplace perl, an now prints a diff when semver files aren't sorted.

It isn't worth keeping a separate rustfmt.toml only for ctest, so switch
to using the vertical formatting everywhere.
@rustbot rustbot added A-CI Area: CI-related items ctest Issues relating to the ctest crate S-waiting-on-review labels Nov 20, 2025
@tgross35 tgross35 enabled auto-merge November 20, 2025 12:04
We need a bit more flexibility in the formatting, which would be
difficult to achieve with bash. Rewrite the style check to a python
script that will be easier to extend. This is also faster than using
inplace perl, an now prints a diff when semver files aren't sorted.
@tgross35 tgross35 added this pull request to the merge queue Nov 20, 2025
Merged via the queue into rust-lang:main with commit 9713fd1 Nov 20, 2025
50 checks passed
@tgross35 tgross35 deleted the style-script branch November 20, 2025 12:38
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Dec 2, 2025
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Dec 2, 2025
It isn't worth keeping a separate rustfmt.toml only for ctest, so switch
to using the vertical formatting everywhere.

(backport <rust-lang#4842>)
(cherry picked from commit 04ab55d)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Dec 2, 2025
We need a bit more flexibility in the formatting, which would be
difficult to achieve with bash. Rewrite the style check to a python
script that will be easier to extend. This is also faster than using
inplace perl, an now prints a diff when semver files aren't sorted.

(backport <rust-lang#4842>)
(cherry picked from commit 9713fd1)
@tgross35 tgross35 mentioned this pull request Dec 2, 2025
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Dec 2, 2025
It isn't worth keeping a separate rustfmt.toml only for ctest, so switch
to using the vertical formatting everywhere.

(backport <rust-lang#4842>)
(cherry picked from commit 04ab55d)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Dec 2, 2025
We need a bit more flexibility in the formatting, which would be
difficult to achieve with bash. Rewrite the style check to a python
script that will be easier to extend. This is also faster than using
inplace perl, an now prints a diff when semver files aren't sorted.

(backport <rust-lang#4842>)
(cherry picked from commit 9713fd1)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Dec 2, 2025
It isn't worth keeping a separate rustfmt.toml only for ctest, so switch
to using the vertical formatting everywhere.

(backport <rust-lang#4842>)
(cherry picked from commit 04ab55d)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Dec 2, 2025
We need a bit more flexibility in the formatting, which would be
difficult to achieve with bash. Rewrite the style check to a python
script that will be easier to extend. This is also faster than using
inplace perl, an now prints a diff when semver files aren't sorted.

(backport <rust-lang#4842>)
(cherry picked from commit 9713fd1)
github-merge-queue bot pushed a commit that referenced this pull request Dec 2, 2025
It isn't worth keeping a separate rustfmt.toml only for ctest, so switch
to using the vertical formatting everywhere.

(backport <#4842>)
(cherry picked from commit 04ab55d)
github-merge-queue bot pushed a commit that referenced this pull request Dec 2, 2025
We need a bit more flexibility in the formatting, which would be
difficult to achieve with bash. Rewrite the style check to a python
script that will be easier to extend. This is also faster than using
inplace perl, an now prints a diff when semver files aren't sorted.

(backport <#4842>)
(cherry picked from commit 9713fd1)
github-merge-queue bot pushed a commit that referenced this pull request Dec 2, 2025
It isn't worth keeping a separate rustfmt.toml only for ctest, so switch
to using the vertical formatting everywhere.

(backport <#4842>)
(cherry picked from commit 04ab55d)
github-merge-queue bot pushed a commit that referenced this pull request Dec 2, 2025
We need a bit more flexibility in the formatting, which would be
difficult to achieve with bash. Rewrite the style check to a python
script that will be easier to extend. This is also faster than using
inplace perl, an now prints a diff when semver files aren't sorted.

(backport <#4842>)
(cherry picked from commit 9713fd1)
github-merge-queue bot pushed a commit that referenced this pull request Dec 2, 2025
It isn't worth keeping a separate rustfmt.toml only for ctest, so switch
to using the vertical formatting everywhere.

(backport <#4842>)
(cherry picked from commit 04ab55d)
github-merge-queue bot pushed a commit that referenced this pull request Dec 2, 2025
We need a bit more flexibility in the formatting, which would be
difficult to achieve with bash. Rewrite the style check to a python
script that will be easier to extend. This is also faster than using
inplace perl, an now prints a diff when semver files aren't sorted.

(backport <#4842>)
(cherry picked from commit 9713fd1)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: CI-related items ctest Issues relating to the ctest crate stable-applied This PR has been cherry-picked to libc's stable release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants