-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fmt: Replace style.sh with style.py #4842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It isn't worth keeping a separate rustfmt.toml only for ctest, so switch to using the vertical formatting everywhere.
We need a bit more flexibility in the formatting, which would be difficult to achieve with bash. Rewrite the style check to a python script that will be easier to extend. This is also faster than using inplace perl, an now prints a diff when semver files aren't sorted.
dd0d2b8 to
9da2ec9
Compare
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Dec 2, 2025
It isn't worth keeping a separate rustfmt.toml only for ctest, so switch to using the vertical formatting everywhere. (backport <rust-lang#4842>) (cherry picked from commit 04ab55d)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Dec 2, 2025
We need a bit more flexibility in the formatting, which would be difficult to achieve with bash. Rewrite the style check to a python script that will be easier to extend. This is also faster than using inplace perl, an now prints a diff when semver files aren't sorted. (backport <rust-lang#4842>) (cherry picked from commit 9713fd1)
Merged
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Dec 2, 2025
It isn't worth keeping a separate rustfmt.toml only for ctest, so switch to using the vertical formatting everywhere. (backport <rust-lang#4842>) (cherry picked from commit 04ab55d)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Dec 2, 2025
We need a bit more flexibility in the formatting, which would be difficult to achieve with bash. Rewrite the style check to a python script that will be easier to extend. This is also faster than using inplace perl, an now prints a diff when semver files aren't sorted. (backport <rust-lang#4842>) (cherry picked from commit 9713fd1)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Dec 2, 2025
It isn't worth keeping a separate rustfmt.toml only for ctest, so switch to using the vertical formatting everywhere. (backport <rust-lang#4842>) (cherry picked from commit 04ab55d)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Dec 2, 2025
We need a bit more flexibility in the formatting, which would be difficult to achieve with bash. Rewrite the style check to a python script that will be easier to extend. This is also faster than using inplace perl, an now prints a diff when semver files aren't sorted. (backport <rust-lang#4842>) (cherry picked from commit 9713fd1)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 2, 2025
We need a bit more flexibility in the formatting, which would be difficult to achieve with bash. Rewrite the style check to a python script that will be easier to extend. This is also faster than using inplace perl, an now prints a diff when semver files aren't sorted. (backport <#4842>) (cherry picked from commit 9713fd1)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 2, 2025
We need a bit more flexibility in the formatting, which would be difficult to achieve with bash. Rewrite the style check to a python script that will be easier to extend. This is also faster than using inplace perl, an now prints a diff when semver files aren't sorted. (backport <#4842>) (cherry picked from commit 9713fd1)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 2, 2025
We need a bit more flexibility in the formatting, which would be difficult to achieve with bash. Rewrite the style check to a python script that will be easier to extend. This is also faster than using inplace perl, an now prints a diff when semver files aren't sorted. (backport <#4842>) (cherry picked from commit 9713fd1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-CI
Area: CI-related items
ctest
Issues relating to the ctest crate
stable-applied
This PR has been cherry-picked to libc's stable release branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need a bit more flexibility in the formatting, which would be
difficult to achieve with bash. Rewrite the style check to a python
script that will be easier to extend. This is also faster than using
inplace perl, an now prints a diff when semver files aren't sorted.