Skip to content

Add support for specifying split-debuginfo=unpacked output directory #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 of 3 tasks
durin42 opened this issue Apr 29, 2025 · 1 comment
Open
1 of 3 tasks
Labels
major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@durin42
Copy link

durin42 commented Apr 29, 2025

Proposal

We've encountered users that depend on .dwo objects being directly-loadable by their debugger, rather than relying on the merged .dwp file at the end of the build of the binary or test. A complicating factor is that we're using bazel with remote execution exclusively, so we have to be able to list either exact filenames or directories of a single type before executing any tools[0]. Originally we were using a helper binary that wrapped rustc to move the .dwo files to a known-upfront directory, but this breaks debugging (experimentally lldb will print lots of warnings upon not finding the dwo file, gdb will just crash). As a result, we'd like a flag to control where the .dwo files get written - in my draft patch I used -Zsplit-dwarf-out-dir= but that's obviously open to revision.

I'm not sure if we should land this now: one immediate concern I have is that we haven't yet done FDO/PGO work in bazel, and that seems like it might have similar interactions with the compiler. Semi-related past work: rust-lang/rust@aa91871 where we added support for writing summary bitcode for distributed ThinLTO.

0: bazel calls this the analysis phase - as contrasted with the execution phase. It's a hard constraint in bazel's design that all artifacts it will collect be listed out by name before the execution phase starts.

Mentors or Reviewers

The actual patches are simple enough I can probably self-mentor? Not sure who should review.

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

@durin42 durin42 added major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team labels Apr 29, 2025
@rustbot
Copy link
Collaborator

rustbot commented Apr 29, 2025

Important

This issue is not meant to be used for technical discussion. There is a Zulip stream for that.
Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

Concerns or objections can formally be registered here by adding a comment.

@rfcbot concern reason-for-concern
<description of the concern>

Concerns can be lifted with:

@rfcbot resolve reason-for-concern

See documentation at https://forge.rust-lang.org

cc @rust-lang/compiler

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Apr 29, 2025
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Development

No branches or pull requests

3 participants