Skip to content

Introduce debug information to statements in MIR #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 of 3 tasks
dianqk opened this issue Apr 26, 2025 · 1 comment
Open
1 of 3 tasks

Introduce debug information to statements in MIR #867

dianqk opened this issue Apr 26, 2025 · 1 comment
Labels
major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@dianqk
Copy link
Member

dianqk commented Apr 26, 2025

Proposal

Currently, the MIR optimization passes are unable to eliminate dead statements that contain debug information. For example:

struct Foo {
    v1: i32,
    v2: i32
}

#[no_mangle]
fn foo(foo: Foo) {
    let _val = foo.v2; // Because we need the debug information to know the value of `_val` at this point, we cannot eliminate this statement.
}

To enable more optimizations within MIR, I propose adding debug information to Statement. This will allow us to preserve necessary debug information while eliminating the statements when they are dead.

Mentors or Reviewers

@wesleywiser (because of your work on MIR optimizations and debug information)

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

@dianqk dianqk added major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team labels Apr 26, 2025
@rustbot
Copy link
Collaborator

rustbot commented Apr 26, 2025

Important

This issue is not meant to be used for technical discussion. There is a Zulip stream for that.
Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

Concerns or objections can formally be registered here by adding a comment.

@rfcbot concern reason-for-concern
<description of the concern>

Concerns can be lifted with:

@rfcbot resolve reason-for-concern

See documentation at https://forge.rust-lang.org

cc @rust-lang/compiler

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Apr 26, 2025
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Development

No branches or pull requests

3 participants