Merge tcharding/rust-psbt#37: Clean up dependencies, feature flags, format, lint, and kick the tires on rbmt

233ff10 Fix version numbers for synced code (Nick Johnson)
085b9b9 Fix up minimal versions (Nick Johnson)
3a8a97b Bump nightly version, fix new lints and format (Nick Johnson)
260081f Switch to rmbt tooling (Nick Johnson)
e8ac0ab Remove unnecssary rand-std flag (Nick Johnson)
c2d88c6 Hide actual-serde feature flag from end users (Nick Johnson)
5c42a53 Combine miniscript feature flags into one (Nick Johnson)
0970655 Match rust-bitcoin's looser encoding requirements (Nick Johnson)

Pull request description:

  Bit of mess,  but the first patch gets the code compiling again, some fallout from the BufRead -> Read change in rust-bitcoin. The next three patches use the 1.60+ rust features for a cleaner feature flag interface with less footguns for users. And finally the rest of the patches introduce the `rbmt` tooling and fix up format, lint, and minimal version issues.

  Supersedes #36
  Closes #32

ACKs for top commit:
  tcharding:
    ACK 233ff10

Tree-SHA512: a4fc0cf6aba8b1b9ebfcaa9214665c344d7f81806999cb5520d55a1fa1cd4f97757bbdf6191b743f55aa9bb50059b4c859d0fbd02155db13e6c75301df69bf59

Author: nyonson

.github/workflows/rust.yml

@@ -16,7 +16,7 @@ jobs:
     steps:
       - name: "Checkout repo"
         uses: actions/checkout@v4
-      - name: "Read nightly version"
+      - name: "Read toolchain versions"
         id: read_toolchain
         run: echo "nightly_version=$(cat nightly-version)" >> $GITHUB_OUTPUT
 
@@ -30,18 +30,12 @@ jobs:
     steps:
       - name: "Checkout repo"
         uses: actions/checkout@v4
-      - name: "Checkout maintainer tools"
-        uses: actions/checkout@v4
-        with:
-          repository: rust-bitcoin/rust-bitcoin-maintainer-tools
-          rev: b2ac115
-          path: maintainer-tools
       - name: "Select toolchain"
         uses: dtolnay/rust-toolchain@stable
-      - name: "Set dependencies"
-        run: cp Cargo-${{ matrix.dep }}.lock Cargo.lock
-      - name: "Run test script"
-        run: ./maintainer-tools/ci/run_task.sh stable
+      - name: "Install rbmt"
+        run: ./contrib/install-rbmt.sh
+      - name: "Run tests"
+        run: rbmt test stable --lock-file ${{ matrix.dep }}
 
   Nightly:                      # 2 jobs, one per lock file.
     name: Test - nightly toolchain
@@ -54,20 +48,14 @@ jobs:
     steps:
       - name: "Checkout repo"
         uses: actions/checkout@v4
-      - name: "Checkout maintainer tools"
-        uses: actions/checkout@v4
-        with:
-          repository: rust-bitcoin/rust-bitcoin-maintainer-tools
-          rev: b2ac115
-          path: maintainer-tools
       - name: "Select toolchain"
         uses: dtolnay/rust-toolchain@v1
         with:
           toolchain: ${{ needs.Prepare.outputs.nightly_version }}
-      - name: "Set dependencies"
-        run: cp Cargo-${{ matrix.dep }}.lock Cargo.lock
-      - name: "Run test script"
-        run: ./maintainer-tools/ci/run_task.sh nightly
+      - name: "Install rbmt"
+        run: ./contrib/install-rbmt.sh
+      - name: "Run tests"
+        run: rbmt test nightly --lock-file ${{ matrix.dep }}
 
   MSRV:                         # 2 jobs, one per lock file.
     name: Test - MSRV toolchain
@@ -79,115 +67,79 @@ jobs:
     steps:
       - name: "Checkout repo"
         uses: actions/checkout@v4
-      - name: "Checkout maintainer tools"
-        uses: actions/checkout@v4
-        with:
-          repository: rust-bitcoin/rust-bitcoin-maintainer-tools
-          rev: b2ac115
-          path: maintainer-tools
-      - name: "Select toolchain"
+      - name: "Install stable toolchain"
+        uses: dtolnay/rust-toolchain@stable
+      - name: "Install rbmt"
+        run: ./contrib/install-rbmt.sh
+      - name: "Install MSRV toolchain"
         uses: dtolnay/rust-toolchain@stable
         with:
           toolchain: "1.63.0"
-      - name: "Set dependencies"
-        run: cp Cargo-${{ matrix.dep }}.lock Cargo.lock
-      - name: "Run test script"
-        run: ./maintainer-tools/ci/run_task.sh msrv
+      - name: "Run tests"
+        run: rbmt test msrv --lock-file ${{ matrix.dep }}
 
   Lint:
     name: Lint - nightly toolchain
     needs: Prepare
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
-      matrix:
-        dep: [recent]
     steps:
       - name: "Checkout repo"
         uses: actions/checkout@v4
-      - name: "Checkout maintainer tools"
-        uses: actions/checkout@v4
-        with:
-          repository: rust-bitcoin/rust-bitcoin-maintainer-tools
-          rev: b2ac115
-          path: maintainer-tools
       - name: "Select toolchain"
         uses: dtolnay/rust-toolchain@v1
         with:
           toolchain: ${{ needs.Prepare.outputs.nightly_version }}
       - name: "Install clippy"
         run: rustup component add clippy
-      - name: "Set dependencies"
-        run: cp Cargo-${{ matrix.dep }}.lock Cargo.lock
-      - name: "Run test script"
-        run: ./maintainer-tools/ci/run_task.sh lint
+      - name: "Install rbmt"
+        run: ./contrib/install-rbmt.sh
+      - name: "Run lint"
+        run: rbmt lint
 
   Docs:
     name: Docs - stable toolchain
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
-      matrix:
-        dep: [recent]
     steps:
       - name: "Checkout repo"
         uses: actions/checkout@v4
-      - name: "Checkout maintainer tools"
-        uses: actions/checkout@v4
-        with:
-          repository: rust-bitcoin/rust-bitcoin-maintainer-tools
-          rev: b2ac115
-          path: maintainer-tools
       - name: "Select toolchain"
         uses: dtolnay/rust-toolchain@stable
-      - name: "Set dependencies"
-        run: cp Cargo-${{ matrix.dep }}.lock Cargo.lock
-      - name: "Run test script"
-        run: ./maintainer-tools/ci/run_task.sh docs
+      - name: "Install rbmt"
+        run: ./contrib/install-rbmt.sh
+      - name: "Build docs"
+        run: rbmt docs
 
   Docsrs:
     name: Docs - nightly toolchain
     needs: Prepare
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
-      matrix:
-        dep: [recent]
     steps:
       - name: "Checkout repo"
         uses: actions/checkout@v4
-      - name: "Checkout maintainer tools"
-        uses: actions/checkout@v4
-        with:
-          repository: rust-bitcoin/rust-bitcoin-maintainer-tools
-          rev: b2ac115
-          path: maintainer-tools
       - name: "Select toolchain"
         uses: dtolnay/rust-toolchain@v1
         with:
           toolchain: ${{ needs.Prepare.outputs.nightly_version }}
-      - name: "Set dependencies"
-        run: cp Cargo-${{ matrix.dep }}.lock Cargo.lock
-      - name: "Run test script"
-        run: ./maintainer-tools/ci/run_task.sh docsrs
+      - name: "Install rbmt"
+        run: ./contrib/install-rbmt.sh
+      - name: "Build docs.rs docs"
+        run: rbmt docsrs
 
   Format:                       #  1 job, run cargo fmt directly.
     name: Format - nightly toolchain
     needs: Prepare
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
-      matrix:
-        dep: [recent]
     steps:
       - name: "Checkout repo"
         uses: actions/checkout@v4
-      - name: "Checkout maintainer tools"
-        uses: actions/checkout@v4
-        with:
-          repository: rust-bitcoin/rust-bitcoin-maintainer-tools
-          rev: b2ac115
-          path: maintainer-tools
       - name: "Select toolchain"
         uses: dtolnay/rust-toolchain@v1
         with: