Don't assume that Qfalse is 0 in rb_special_const_p

peterzhu2118 · eregon · commit 408e230ae183 · 2024-02-27T21:30:34.000+01:00
rb_special_const_p returns a VALUE (Qtrue or Qfalse), so can directly
return the value and we shouldn't assume that Qfalse is 0.
diff --git a/optional/capi/ext/object_spec.c b/optional/capi/ext/object_spec.c
@@ -179,11 +179,7 @@ static VALUE object_spec_rb_method_boundp(VALUE self, VALUE obj, VALUE method, V
 }
 
 static VALUE object_spec_rb_special_const_p(VALUE self, VALUE value) {
-  if (rb_special_const_p(value)) {
-    return Qtrue;
-  } else {
-    return Qfalse;
-  }
+  return rb_special_const_p(value);
 }
 
 static VALUE so_to_id(VALUE self, VALUE obj) {

Original file line number	Diff line number	Diff line change
`@@ -179,11 +179,7 @@ static VALUE object_spec_rb_method_boundp(VALUE self, VALUE obj, VALUE method, V`
`179`	`179`	`}`
`180`	`180`
`181`	`181`	`static VALUE object_spec_rb_special_const_p(VALUE self, VALUE value) {`
`182`		`- if (rb_special_const_p(value)) {`
`183`		`- return Qtrue;`
`184`		`- } else {`
`185`		`- return Qfalse;`
`186`		`- }`
	`182`	`+ return rb_special_const_p(value);`
`187`	`183`	`}`
`188`	`184`
`189`	`185`	`static VALUE so_to_id(VALUE self, VALUE obj) {`