Skip to content

Commit 3b50304

Browse files
larskaniseregon
authored andcommitted
Set default for Encoding.default_external to UTF-8 on Windows (#2877)
* Use UTF-8 as default for Encoding.default_external on Windows * Document UTF-8 change on Windows to Encoding.default_external fix https://bugs.ruby-lang.org/issues/16604
1 parent 611c70f commit 3b50304

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

command_line/dash_upper_k_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@
5858
end
5959

6060
it "ignores unknown codes" do
61-
locale = Encoding.find('locale')
61+
external = Encoding.find('external')
6262
ruby_exe(@test_string, options: '-KZ').should ==
63-
[Encoding::UTF_8.name, locale.name, nil].inspect
63+
[Encoding::UTF_8.name, external.name, nil].inspect
6464
end
6565
end

library/stringio/binmode_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
it "changes external encoding to BINARY" do
1111
io = StringIO.new
12-
io.external_encoding.should == Encoding.find('locale')
12+
io.external_encoding.should == Encoding.find('external')
1313
io.binmode
1414
io.external_encoding.should == Encoding::BINARY
1515
end

0 commit comments

Comments
 (0)