Skip to content

Commit 0b9433d

Browse files
authored
Rename test classes from Test* to *Test (#1359)
Since class names are usually nouns, test classes should be named like `ClassNameTest` instead of `TestClassName`. This convention is now commonly used in projects (e.g. Rails) and tools like Ruby LSP use it to check if a class is a test class. (From tools' perspective, checking `Test` as a postfix is more accurate than checking `Test` as a prefix as `TestHelper`, `TestCase`...etc. are not test classes.) I've previously renamed some classes this way. This commit renames all remaining classes to follow the convention.
1 parent fdaa5a6 commit 0b9433d

File tree

82 files changed

+72
-72
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

82 files changed

+72
-72
lines changed

Rakefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,13 +38,13 @@ end
3838
Rake::TestTask.new(:normal_test) do |t|
3939
t.verbose = true
4040
t.deps = :generate
41-
t.test_files = FileList["test/**/test_*.rb"].exclude("test/rdoc/test_rdoc_rubygems_hook.rb")
41+
t.test_files = FileList["test/**/*_test.rb"].exclude("test/rdoc/rdoc_rubygems_hook_test.rb")
4242
end
4343

4444
Rake::TestTask.new(:rubygems_test) do |t|
4545
t.verbose = true
4646
t.deps = :generate
47-
t.pattern = "test/rdoc/test_rdoc_rubygems_hook.rb"
47+
t.pattern = "test/rdoc/rdoc_rubygems_hook_test.rb"
4848
end
4949

5050
path = "pkg/#{Bundler::GemHelper.gemspec.full_name}"

test/rdoc/test_rdoc_alias.rb renamed to test/rdoc/rdoc_alias_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22
require_relative 'xref_test_case'
33

4-
class TestRDocAlias < XrefTestCase
4+
class RDocAliasTest < XrefTestCase
55

66
def test_to_s
77
a = RDoc::Alias.new nil, 'a', 'b', ''

test/rdoc/test_rdoc_any_method.rb renamed to test/rdoc/rdoc_any_method_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22
require_relative 'xref_test_case'
33

4-
class TestRDocAnyMethod < XrefTestCase
4+
class RDocAnyMethodTest < XrefTestCase
55

66
def test_aref
77
m = RDoc::AnyMethod.new nil, 'method?'

test/rdoc/test_rdoc_attr.rb renamed to test/rdoc/rdoc_attr_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22
require_relative 'helper'
33

4-
class TestRDocAttr < RDoc::TestCase
4+
class RDocAttrTest < RDoc::TestCase
55

66
def setup
77
super

test/rdoc/test_rdoc_code_object.rb renamed to test/rdoc/rdoc_code_object_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
require_relative 'xref_test_case'
55

6-
class TestRDocCodeObject < XrefTestCase
6+
class RDocCodeObjectTest < XrefTestCase
77

88
def setup
99
super
File renamed without changes.

test/rdoc/test_rdoc_constant.rb renamed to test/rdoc/rdoc_constant_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22
require_relative 'xref_test_case'
33

4-
class TestRDocConstant < XrefTestCase
4+
class RDocConstantTest < XrefTestCase
55

66
def setup
77
super

test/rdoc/test_rdoc_context_section.rb renamed to test/rdoc/rdoc_context_section_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22
require_relative 'helper'
33

4-
class TestRDocContextSection < RDoc::TestCase
4+
class RDocContextSectionTest < RDoc::TestCase
55

66
def setup
77
super

test/rdoc/test_rdoc_context.rb renamed to test/rdoc/rdoc_context_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22
require_relative 'xref_test_case'
33

4-
class TestRDocContext < XrefTestCase
4+
class RDocContextTest < XrefTestCase
55

66
def setup
77
super

test/rdoc/test_rdoc_cross_reference.rb renamed to test/rdoc/rdoc_cross_reference_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22
require_relative 'xref_test_case'
33

4-
class TestRDocCrossReference < XrefTestCase
4+
class RDocCrossReferenceTest < XrefTestCase
55
EXAMPLE_METHODS = %w'== === != =~ !~ < > <= >= <=> [] []= << >>
66
-@ +@ ! - + * / % ** !@ ` | & ^ ~ __id__
77
'

test/rdoc/test_rdoc_encoding.rb renamed to test/rdoc/rdoc_encoding_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
require_relative 'helper'
55

6-
class TestRDocEncoding < RDoc::TestCase
6+
class RDocEncodingTest < RDoc::TestCase
77

88
def setup
99
super

test/rdoc/test_rdoc_extend.rb renamed to test/rdoc/rdoc_extend_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22
require_relative 'xref_test_case'
33

4-
class TestRDocExtend < XrefTestCase
4+
class RDocExtendTest < XrefTestCase
55

66
def setup
77
super

test/rdoc/test_rdoc_generator_json_index.rb renamed to test/rdoc/rdoc_generator_json_index_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
require_relative 'helper'
55

6-
class TestRDocGeneratorJsonIndex < RDoc::TestCase
6+
class RDocGeneratorJsonIndexTest < RDoc::TestCase
77

88
def setup
99
super

test/rdoc/test_rdoc_generator_markup.rb renamed to test/rdoc/rdoc_generator_markup_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22
require_relative 'helper'
33

4-
class TestRDocGeneratorMarkup < RDoc::TestCase
4+
class RDocGeneratorMarkupTest < RDoc::TestCase
55

66
include RDoc::Text
77
include RDoc::Generator::Markup

test/rdoc/test_rdoc_generator_pot_po_entry.rb renamed to test/rdoc/rdoc_generator_pot_po_entry_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22
require_relative 'helper'
33

4-
class TestRDocGeneratorPOTPOEntry < RDoc::TestCase
4+
class RDocGeneratorPOTPOEntryTest < RDoc::TestCase
55

66
def test_msgid_normal
77
assert_equal <<-'ENTRY', entry("Hello", {}).to_s

test/rdoc/test_rdoc_generator_pot_po.rb renamed to test/rdoc/rdoc_generator_pot_po_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22
require_relative 'helper'
33

4-
class TestRDocGeneratorPOTPO < RDoc::TestCase
4+
class RDocGeneratorPOTPOTest < RDoc::TestCase
55

66
def setup
77
super

test/rdoc/test_rdoc_generator_pot.rb renamed to test/rdoc/rdoc_generator_pot_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22
require_relative 'helper'
33

4-
class TestRDocGeneratorPOT < RDoc::TestCase
4+
class RDocGeneratorPOTTest < RDoc::TestCase
55

66
def setup
77
super

test/rdoc/test_rdoc_generator_ri.rb renamed to test/rdoc/rdoc_generator_ri_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22
require_relative 'helper'
33

4-
class TestRDocGeneratorRI < RDoc::TestCase
4+
class RDocGeneratorRITest < RDoc::TestCase
55

66
def setup
77
super

test/rdoc/test_rdoc_i18n_locale.rb renamed to test/rdoc/rdoc_i18n_locale_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22
require_relative 'helper'
33

4-
class TestRDocI18nLocale < RDoc::TestCase
4+
class RDocI18nLocaleTest < RDoc::TestCase
55

66
def setup
77
super

test/rdoc/test_rdoc_i18n_text.rb renamed to test/rdoc/rdoc_i18n_text_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22
require_relative 'helper'
33

4-
class TestRDocI18nText < RDoc::TestCase
4+
class RDocI18nTextTest < RDoc::TestCase
55

66
def test_multiple_paragraphs
77
paragraph1 = <<-PARAGRAPH.strip

test/rdoc/test_rdoc_include.rb renamed to test/rdoc/rdoc_include_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22
require_relative 'xref_test_case'
33

4-
class TestRDocInclude < XrefTestCase
4+
class RDocIncludeTest < XrefTestCase
55

66
def setup
77
super

test/rdoc/test_rdoc_markdown.rb renamed to test/rdoc/rdoc_markdown_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
require_relative '../../lib/rdoc/markup/block_quote'
66
require_relative '../../lib/rdoc/markdown'
77

8-
class TestRDocMarkdown < RDoc::TestCase
8+
class RDocMarkdownTest < RDoc::TestCase
99

1010
def setup
1111
super

test/rdoc/test_rdoc_markdown_test.rb renamed to test/rdoc/rdoc_markdown_test_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
require_relative '../../lib/rdoc'
66
require_relative '../../lib/rdoc/markdown'
77

8-
class TestRDocMarkdownTest < RDoc::TestCase
8+
class RDocMarkdownTestTest < RDoc::TestCase
99

1010
MARKDOWN_TEST_PATH = File.expand_path '../MarkdownTest_1.0.3/', __FILE__
1111

test/rdoc/test_rdoc_markup_attribute_manager.rb renamed to test/rdoc/rdoc_markup_attribute_manager_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22
require_relative 'helper'
33

4-
class TestRDocMarkupAttributeManager < RDoc::TestCase
4+
class RDocMarkupAttributeManagerTest < RDoc::TestCase
55

66
def setup
77
super

test/rdoc/test_rdoc_markup_attributes.rb renamed to test/rdoc/rdoc_markup_attributes_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22
require_relative 'helper'
33

4-
class TestRDocMarkupAttributes < RDoc::TestCase
4+
class RDocMarkupAttributesTest < RDoc::TestCase
55

66
def setup
77
super

test/rdoc/test_rdoc_markup_document.rb renamed to test/rdoc/rdoc_markup_document_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22
require_relative 'helper'
33

4-
class TestRDocMarkupDocument < RDoc::TestCase
4+
class RDocMarkupDocumentTest < RDoc::TestCase
55

66
def setup
77
super

test/rdoc/test_rdoc_markup_formatter.rb renamed to test/rdoc/rdoc_markup_formatter_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22
require_relative 'helper'
33

4-
class TestRDocMarkupFormatter < RDoc::TestCase
4+
class RDocMarkupFormatterTest < RDoc::TestCase
55

66
class ToTest < RDoc::Markup::Formatter
77

test/rdoc/test_rdoc_markup_hard_break.rb renamed to test/rdoc/rdoc_markup_hard_break_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22
require_relative 'helper'
33

4-
class TestRDocMarkupHardBreak < RDoc::TestCase
4+
class RDocMarkupHardBreakTest < RDoc::TestCase
55

66
def setup
77
super

test/rdoc/test_rdoc_markup_heading.rb renamed to test/rdoc/rdoc_markup_heading_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22
require_relative 'helper'
33

4-
class TestRDocMarkupHeading < RDoc::TestCase
4+
class RDocMarkupHeadingTest < RDoc::TestCase
55

66
def setup
77
super

test/rdoc/test_rdoc_markup_include.rb renamed to test/rdoc/rdoc_markup_include_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22
require_relative 'helper'
33

4-
class TestRDocMarkupInclude < RDoc::TestCase
4+
class RDocMarkupIncludeTest < RDoc::TestCase
55

66
def setup
77
super

test/rdoc/test_rdoc_markup_indented_paragraph.rb renamed to test/rdoc/rdoc_markup_indented_paragraph_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22
require_relative 'helper'
33

4-
class TestRDocMarkupIndentedParagraph < RDoc::TestCase
4+
class RDocMarkupIndentedParagraphTest < RDoc::TestCase
55

66
def setup
77
super

test/rdoc/test_rdoc_markup_paragraph.rb renamed to test/rdoc/rdoc_markup_paragraph_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22
require_relative 'helper'
33

4-
class TestRDocMarkupParagraph < RDoc::TestCase
4+
class RDocMarkupParagraphTest < RDoc::TestCase
55

66
def test_accept
77
visitor = Object.new

test/rdoc/test_rdoc_markup_parser.rb renamed to test/rdoc/rdoc_markup_parser_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
require_relative 'helper'
55

6-
class TestRDocMarkupParser < RDoc::TestCase
6+
class RDocMarkupParserTest < RDoc::TestCase
77

88
def setup
99
super

test/rdoc/test_rdoc_markup_raw.rb renamed to test/rdoc/rdoc_markup_raw_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22
require_relative 'helper'
33

4-
class TestRDocMarkupRaw < RDoc::TestCase
4+
class RDocMarkupRawTest < RDoc::TestCase
55

66
def setup
77
super

test/rdoc/test_rdoc_markup.rb renamed to test/rdoc/rdoc_markup_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22
require_relative 'helper'
33

4-
class TestRDocMarkup < RDoc::TestCase
4+
class RDocMarkupTest < RDoc::TestCase
55

66
def test_class_parse
77
expected = @RM::Document.new(

test/rdoc/test_rdoc_markup_to_html_snippet.rb renamed to test/rdoc/rdoc_markup_to_html_snippet_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22
require_relative 'helper'
33

4-
class TestRDocMarkupToHtmlSnippet < RDoc::Markup::FormatterTestCase
4+
class RDocMarkupToHtmlSnippetTest < RDoc::Markup::FormatterTestCase
55

66
add_visitor_tests
77

test/rdoc/test_rdoc_markup_to_joined_paragraph.rb renamed to test/rdoc/rdoc_markup_to_joined_paragraph_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22
require_relative 'helper'
33

4-
class TestRDocMarkupToJoinedParagraph < RDoc::TestCase
4+
class RDocMarkupToJoinedParagraphTest < RDoc::TestCase
55

66
def setup
77
super

test/rdoc/test_rdoc_markup_to_label.rb renamed to test/rdoc/rdoc_markup_to_label_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22
require_relative 'helper'
33

4-
class TestRDocMarkupToLabel < RDoc::Markup::FormatterTestCase
4+
class RDocMarkupToLabelTest < RDoc::Markup::FormatterTestCase
55

66
add_visitor_tests
77

test/rdoc/test_rdoc_markup_to_table_of_contents.rb renamed to test/rdoc/rdoc_markup_to_table_of_contents_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22
require_relative 'helper'
33

4-
class TestRDocMarkupToTableOfContents < RDoc::Markup::FormatterTestCase
4+
class RDocMarkupToTableOfContentsTest < RDoc::Markup::FormatterTestCase
55

66
add_visitor_tests
77

test/rdoc/test_rdoc_markup_to_tt_only.rb renamed to test/rdoc/rdoc_markup_to_tt_only_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22
require_relative 'helper'
33

4-
class TestRDocMarkupToTtOnly < RDoc::Markup::FormatterTestCase
4+
class RDocMarkupToTtOnlyTest < RDoc::Markup::FormatterTestCase
55

66
add_visitor_tests
77

test/rdoc/test_rdoc_markup_verbatim.rb renamed to test/rdoc/rdoc_markup_verbatim_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22
require_relative 'helper'
33

4-
class TestRDocMarkupVerbatim < RDoc::TestCase
4+
class RDocMarkupVerbatimTest < RDoc::TestCase
55

66
def test_equals2
77
v1 = verb('1 + 1')

test/rdoc/test_rdoc_method_attr.rb renamed to test/rdoc/rdoc_method_attr_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22
require_relative 'xref_test_case'
33

4-
class TestRDocMethodAttr < XrefTestCase
4+
class RDocMethodAttrTest < XrefTestCase
55

66
def test_initialize_copy
77
refute_same @c1_m.full_name, @c1_m.dup.full_name

test/rdoc/test_rdoc_normal_class.rb renamed to test/rdoc/rdoc_normal_class_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22
require_relative 'xref_test_case'
33

4-
class TestRDocNormalClass < XrefTestCase
4+
class RDocNormalClassTest < XrefTestCase
55

66
def test_ancestors
77
klass = @top_level.add_class RDoc::NormalClass, 'Klass'

test/rdoc/test_rdoc_normal_module.rb renamed to test/rdoc/rdoc_normal_module_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22
require_relative 'xref_test_case'
33

4-
class TestRDocNormalModule < XrefTestCase
4+
class RDocNormalModuleTest < XrefTestCase
55

66
def setup
77
super

0 commit comments

Comments
 (0)