Skip to content

Commit 17762fa

Browse files
committed
Quiet ar with ARFLAGS rather than > null & Remove CC ?= cc
`CC`, `AR` and `ARFLAGS` are all implicit variables in GNU `make` (the `README` _specifies GNU_ `make`). `CC` and `AR` already defaulted appropriately (and turns out, `CC ?=` doesn’t overwrite the default). `ARFLAGS` defaulted verbose, so un-verbose-fy it is the more direct *and platform-agnostic* way to quiet `ar`.
1 parent 26f9fcf commit 17762fa

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ SOEXT ?= $(shell ruby -e 'puts RbConfig::CONFIG["SOEXT"]')
1212

1313
CPPFLAGS := -Iinclude $(CPPFLAGS)
1414
CFLAGS := -g -O2 -std=c99 -Wall -Werror -Wextra -Wpedantic -Wundef -Wconversion -Wno-missing-braces -fPIC -fvisibility=hidden $(CFLAGS)
15-
CC ?= cc
15+
ARFLAGS := -r
1616
WASI_SDK_PATH := /opt/wasi-sdk
1717

1818
MAKEDIRS ?= mkdir -p
@@ -36,7 +36,7 @@ build/libprism.$(SOEXT): $(SHARED_OBJECTS)
3636

3737
build/libprism.a: $(STATIC_OBJECTS)
3838
$(ECHO) "building $@"
39-
$(Q) $(AR) $(ARFLAGS) $@ $(STATIC_OBJECTS) $(Q1:0=>/dev/null)
39+
$(Q) $(AR) $(ARFLAGS) $@ $(STATIC_OBJECTS)
4040

4141
javascript/src/prism.wasm: Makefile $(SOURCES) $(HEADERS)
4242
$(ECHO) "building $@"

0 commit comments

Comments
 (0)