Merge pull request #42 from rubberduck-vba/webhook

retailcoder · web-flow · commit a6874838754d · 2025-02-04T17:00:57.000-05:00
Webhook: fix exception with stream reader
diff --git a/rubberduckvba.Server/GitHubAuthenticationHandler.cs b/rubberduckvba.Server/GitHubAuthenticationHandler.cs
@@ -75,7 +75,9 @@ protected async override Task<AuthenticateResult> HandleAuthenticateAsync()
             }
 
             var signature = xHubSignature256.SingleOrDefault();
-            var payload = new StreamReader(Context.Request.Body).ReadToEnd();
+
+            using var reader = new StreamReader(Context.Request.Body);
+            var payload = reader.ReadToEndAsync().GetAwaiter().GetResult();
 
             if (!IsValidSignature(signature, payload))
             {

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,9 @@ protected async override Task<AuthenticateResult> HandleAuthenticateAsync()`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`var signature = xHubSignature256.SingleOrDefault();`
`78`		`- var payload = new StreamReader(Context.Request.Body).ReadToEnd();`
	`78`	`+`
	`79`	`+ using var reader = new StreamReader(Context.Request.Body);`
	`80`	`+ var payload = reader.ReadToEndAsync().GetAwaiter().GetResult();`
`79`	`81`
`80`	`82`	`if (!IsValidSignature(signature, payload))`
`81`	`83`	`{`