Skip to content

Commit 6e6f9e5

Browse files
committed
update note and add TODOs
1 parent f368aef commit 6e6f9e5

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

Rmd/plotlee.Rmd

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,9 @@ static_img_formats <- c("eps", "pdf", "png", "ps", "webp")
4343

4444
NOTES:
4545

46-
- To initialize reticulate's default shared Python virtualenv `r-reticulate`, run `reticulate::virtualenv_create()`. After that, reticulate won't nudge to use
47-
miniconda anymore.
46+
- To initialize reticulate's default shared Python virtualenv `r-reticulate`, run `reticulate::virtualenv_create()`. Before reticulate
47+
[v1.31](https://github.com/rstudio/reticulate/releases/tag/v1.31), it nudged to install miniconda if this virtualenv didn't exist. Latest reticulate
48+
automatically proposes to create this virtualenv 🎉!
4849

4950
- `rsvg::rsvg_*()` handles unused transparent space around the input SVG differently for the different output formats. `rsvg::rsvg_eps/pdf/ps()` do not
5051
properly handle viewbox-cropped SVGs, while `rsvg::rsvg_png/webp` do. Thus we account for this in the function's logic.

TODO.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
# TODOs
2+
3+
- carefully read reticulate's updated [`python_dependencies` vignette](https://rstudio.github.io/reticulate/articles/python_dependencies.html) and improve
4+
plotlee's default Python setup accordingly (if sensible)

0 commit comments

Comments
 (0)