Handle invalid floats in points of arrow marker (#1471)

rhaschke · web-flow · commit 6bf59755eb21 · 2020-02-09T10:20:02.000+01:00
diff --git a/src/rviz/default_plugin/marker_utils.cpp b/src/rviz/default_plugin/marker_utils.cpp
@@ -224,7 +224,10 @@ void checkPointsArrow(const visualization_msgs::Marker& marker, std::stringstrea
     addSeparatorIfRequired(ss);
     ss << "Number of points for an ARROW marker should be either 0 or 2.";
     increaseLevel(::ros::console::levels::Error, level);
+    return;
   }
+  for (const auto& p : marker.points)
+    checkFloats(p, ss, level);
 }
 
 void checkPointsNotEmpty(const visualization_msgs::Marker& marker, std::stringstream& ss, ::ros::console::levels::Level& level)

Original file line number	Diff line number	Diff line change
`@@ -224,7 +224,10 @@ void checkPointsArrow(const visualization_msgs::Marker& marker, std::stringstrea`
`224`	`224`	`addSeparatorIfRequired(ss);`
`225`	`225`	`ss << "Number of points for an ARROW marker should be either 0 or 2.";`
`226`	`226`	`increaseLevel(::ros::console::levels::Error, level);`
	`227`	`+ return;`
`227`	`228`	`}`
	`229`	`+ for (const auto& p : marker.points)`
	`230`	`+ checkFloats(p, ss, level);`
`228`	`231`	`}`
`229`	`232`
`230`	`233`	`void checkPointsNotEmpty(const visualization_msgs::Marker& marker, std::stringstream& ss, ::ros::console::levels::Level& level)`