Upgrade string formatting

ruff check --select=UP031,UP032,FLY --fix

Author: auscompgeek

docs/conf.py

@@ -46,15 +46,15 @@
 
 intersphinx_mapping = {
     "commandsv1": (
-        "https://robotpy.readthedocs.io/projects/commands-v1/en/%s/" % rtd_version,
+        f"https://robotpy.readthedocs.io/projects/commands-v1/en/{rtd_version}/",
         None,
     ),
     "networktables": (
-        "https://robotpy.readthedocs.io/projects/pynetworktables/en/%s/" % rtd_version,
+        f"https://robotpy.readthedocs.io/projects/pynetworktables/en/{rtd_version}/",
         None,
     ),
     "wpilib": (
-        "https://robotpy.readthedocs.io/projects/wpilib/en/%s/" % rtd_version,
+        f"https://robotpy.readthedocs.io/projects/wpilib/en/{rtd_version}/",
         None,
     ),
 }

magicbot/inject.py

@@ -73,15 +73,13 @@ def find_injections(
         # Raise error if injectable syntax used but no injectable was found.
         if injectable is None:
             raise MagicInjectError(
-                "Component %s has variable %s (type %s), which is absent from robot"
-                % (cname, n, inject_type)
+                f"Component {cname} has variable {n} (type {inject_type}), which is absent from robot"
             )
 
         # Raise error if injectable declared with type different than the initial type
         if not isinstance(injectable, inject_type):
             raise MagicInjectError(
-                "Component %s variable %s does not match type in robot! (Got %s, expected %s)"
-                % (cname, n, type(injectable), inject_type)
+                f"Component {cname} variable {n} does not match type in robot! (Got {type(injectable)}, expected {inject_type})"
             )
 
         to_inject[n] = injectable

magicbot/magic_tunable.py

@@ -185,9 +185,9 @@ def setup_tunables(component, cname: str, prefix: Optional[str] = "components")
     cls = component.__class__
 
     if prefix is None:
-        prefix = "/%s" % cname
+        prefix = f"/{cname}"
     else:
-        prefix = "/%s/%s" % (prefix, cname)
+        prefix = f"/{prefix}/{cname}"
 
     NetworkTables = NetworkTableInstance.getDefault()
 
@@ -202,9 +202,9 @@ def setup_tunables(component, cname: str, prefix: Optional[str] = "components")
             continue
 
         if prop._ntsubtable:
-            key = "%s/%s/%s" % (prefix, prop._ntsubtable, n)
+            key = f"{prefix}/{prop._ntsubtable}/{n}"
         else:
-            key = "%s/%s" % (prefix, n)
+            key = f"{prefix}/{n}"
 
         topic = prop._topic_type(NetworkTables.getTopic(key))
         ntvalue = topic.getEntry(prop._ntdefault)
@@ -344,9 +344,9 @@ def collect_feedbacks(component, cname: str, prefix: Optional[str] = "components
     .. note:: This isn't useful for normal use.
     """
     if prefix is None:
-        prefix = "/%s" % cname
+        prefix = f"/{cname}"
     else:
-        prefix = "/%s/%s" % (prefix, cname)
+        prefix = f"/{prefix}/{cname}"
 
     nt = NetworkTableInstance.getDefault().getTable(prefix)
     feedbacks = []

magicbot/magicrobot.py

@@ -609,8 +609,7 @@ def _create_components(self) -> None:
             # If the type is not actually a type, give a meaningful error
             if not isinstance(ctyp, type):
                 raise TypeError(
-                    "%s has a non-type annotation on %s (%r); lone non-injection variable annotations are disallowed, did you want to assign a static variable?"
-                    % (cls.__name__, m, ctyp)
+                    f"{cls.__name__} has a non-type annotation on {m} ({ctyp!r}); lone non-injection variable annotations are disallowed, did you want to assign a static variable?"
                 )
 
             component = self._create_component(m, ctyp, injectables)
@@ -690,8 +689,7 @@ def _create_component(self, name: str, ctyp: type, injectables: Dict[str, Any]):
         # Ensure that mandatory methods are there
         if not callable(getattr(component, "execute", None)):
             raise ValueError(
-                "Component %s (%r) must have a method named 'execute'"
-                % (name, component)
+                f"Component {name} ({component!r}) must have a method named 'execute'"
             )
 
         # Automatically inject a logger object

magicbot/state_machine.py

@@ -84,7 +84,7 @@ def __init__(
 
         if invalid_args:
             raise ValueError(
-                "Invalid parameter names in %s: %s" % (name, ",".join(invalid_args))
+                "Invalid parameter names in {}: {}".format(name, ",".join(invalid_args))
             )
 
         self.name = name
@@ -135,7 +135,7 @@ def __set_name__(self, owner: type, name: str) -> None:
 class _StateData:
     def __init__(self, wrapper: _State) -> None:
         self.name = wrapper.name
-        self.duration_attr = "%s_duration" % self.name
+        self.duration_attr = f"{self.name}_duration"
         self.expires: float = 0xFFFFFFFF
         self.ran = False
         self.run = wrapper.run

robotpy_ext/autonomous/selector.py

@@ -151,7 +151,7 @@ def __init__(self, autonomous_pkgname, *args, **kwargs):
                     if mode_name in self.modes:
                         if not wpilib.DriverStation.isFMSAttached():
                             raise RuntimeError(
-                                "Duplicate name %s in %s" % (mode_name, module_filename)
+                                f"Duplicate name {mode_name} in {module_filename}"
                             )
 
                         logger.error(
@@ -195,8 +195,7 @@ def __init__(self, autonomous_pkgname, *args, **kwargs):
         elif len(default_modes) != 1:
             if not wpilib.DriverStation.isFMSAttached():
                 raise RuntimeError(
-                    "More than one autonomous mode was specified as default! (modes: %s)"
-                    % (", ".join(default_modes))
+                    "More than one autonomous mode was specified as default! (modes: {})".format(", ".join(default_modes))
                 )
 
         # must PutData after setting up objects

robotpy_ext/autonomous/stateful_autonomous.py

@@ -39,7 +39,7 @@ def __init__(self, f: Callable, first: bool):
                 )
             if arg.kind is arg.KEYWORD_ONLY:
                 raise ValueError(
-                    "Cannot use keyword-only parameters for function %s" % name
+                    f"Cannot use keyword-only parameters for function {name}"
                 )
             if arg.name in allowed_args:
                 args.append(arg.name)
@@ -48,7 +48,7 @@ def __init__(self, f: Callable, first: bool):
 
         if invalid_args:
             raise ValueError(
-                "Invalid parameter names in %s: %s" % (name, ",".join(invalid_args))
+                "Invalid parameter names in {}: {}".format(name, ",".join(invalid_args))
             )
 
         functools.update_wrapper(self, f)
@@ -271,22 +271,22 @@ def register_sd_var(self, name, default, add_prefix=True, vmin=-1, vmax=1):
 
         # communicate the min/max value for numbers to the dashboard
         if is_number:
-            name = "%s|%0.3f|%0.3f" % (name, vmin, vmax)
+            name = f"{name}|{vmin:0.3f}|{vmax:0.3f}"
 
         self.__tunables.append(name)
         self.__table.putStringArray(self.MODE_NAME + "_tunables", self.__tunables)
 
     def __register_sd_var_internal(self, name, default, add_prefix, readback):
         if " " in name:
             raise ValueError(
-                "ERROR: Cannot use spaces in a tunable variable name (%s)" % name
+                f"ERROR: Cannot use spaces in a tunable variable name ({name})"
             )
 
         is_number = False
         sd_name = name
 
         if add_prefix:
-            sd_name = "%s\\%s" % (self.MODE_NAME, name)
+            sd_name = f"{self.MODE_NAME}\\{name}"
 
         if isinstance(default, bool):
             self.__table.putBoolean(sd_name, default)

robotpy_ext/common_drivers/driver_base.py

@@ -16,7 +16,5 @@ def __init__(self):
         """
         if not self.verified:
             print(
-                "Warning, device driver {} has not been verified yet, please use with caution!".format(
-                    self.__class__.__name__
-                )
+                f"Warning, device driver {self.__class__.__name__} has not been verified yet, please use with caution!"
             )