better error messages

Author: TheTripleV

commands2/button/joystickbutton.py

@@ -18,4 +18,10 @@ def __init__(self, joystick: Joystick, button: int) -> None:
         :param joystick: The joystick on which the button is located.
         :param button: The number of the button on the joystick.
         """
+        if not isinstance(joystick, Joystick) or not isinstance(button, int):
+            raise TypeError(
+                "JoystickButton.__init__(): incompatible constructor arguments. The following argument types are supported:\n"
+                "\t1. commands2.button.JoystickButton(joystick: Joystick, button: int)\n"
+                f"Invoked with: {joystick}, {button}"
+            )
         super().__init__(lambda: joystick.getRawButton(button))

commands2/button/networkbutton.py

@@ -34,6 +34,10 @@ def __init__(self, *args, **kwargs) -> None:
         num_args = len(args) + len(kwargs)
         if num_args == 1:
             entry: NetworkTableEntry = kwargs.get("entry") or args[0]
+
+            if not isinstance(entry, NetworkTableEntry):
+                raise self._type_error(entry)
+            
             super().__init__(
                 lambda: NetworkTables.isConnected() and entry.getBoolean(False)
             )
@@ -47,6 +51,13 @@ def __init__(self, *args, **kwargs) -> None:
             entry = table.getEntry(field)
             self.__init__(entry)
         else:
-            raise TypeError(
-                f"__init__() takes 1 or 2 positional arguments but {num_args} were given"
-            )
+            raise self._type_error(args)
+
+    def _type_error(self, *args):
+        return TypeError(
+            "NetworkButton.__init__(): incompatible constructor arguments. The following argument types are supported:\n"
+            "\t1. commands2.button.NetworkButton(entry: NetworkTableEntry)\n"
+            "\t2. commands2.button.NetworkButton(table: str, field: str)\n"
+            "\t3. commands2.button.NetworkButton(table: NetworkTable, field: str)\n"
+            f"Invoked with: {', '.join(map(str, args))}"
+        )

commands2/button/povbutton.py

@@ -19,4 +19,10 @@ def __init__(self, joystick: Joystick, angle: int, povNumber: int = 0) -> None:
         :param angle: The angle of the POV corresponding to a button press.
         :param povNumber: The number of the POV on the joystick.
         """
+        if not isinstance(joystick, Joystick) or not isinstance(angle, int) or not isinstance(povNumber, int):
+            raise TypeError(
+                "POVButton.__init__(): incompatible constructor arguments. The following argument types are supported:\n"
+                "\t1. commands2.button.POVButton(joystick: Joystick, angle: int, povNumber: int)\n"
+                f"Invoked with: {joystick}, {angle}, {povNumber}"
+            )
         super().__init__(lambda: joystick.getPOV(povNumber) == angle)