Fix MySQL / PostgreSQL json column compatibility

Omranic · Omranic · commit 912fb04a8336 · 2018-12-22T18:57:25.000+02:00
diff --git a/database/migrations/2017_06_27_143745_create_bookable_bookings_table.php b/database/migrations/2017_06_27_143745_create_bookable_bookings_table.php
@@ -53,8 +53,10 @@ public function down(): void
      */
     protected function jsonable(): string
     {
-        return DB::connection()->getPdo()->getAttribute(PDO::ATTR_DRIVER_NAME) === 'mysql'
-               && version_compare(DB::connection()->getPdo()->getAttribute(PDO::ATTR_SERVER_VERSION), '5.7.8', 'ge')
-            ? 'json' : 'text';
+        $driverName = DB::connection()->getPdo()->getAttribute(PDO::ATTR_DRIVER_NAME);
+        $dbVersion = DB::connection()->getPdo()->getAttribute(PDO::ATTR_SERVER_VERSION);
+        $isOldVersion = version_compare($dbVersion, '5.7.8', 'lt');
+
+        return $driverName === 'mysql' && $isOldVersion ? 'text' : 'json';
     }
 }
diff --git a/database/migrations/2018_04_04_154842_create_ticketable_tickets_table.php b/database/migrations/2018_04_04_154842_create_ticketable_tickets_table.php
@@ -49,8 +49,10 @@ public function down()
      */
     protected function jsonable(): string
     {
-        return DB::connection()->getPdo()->getAttribute(PDO::ATTR_DRIVER_NAME) === 'mysql'
-               && version_compare(DB::connection()->getPdo()->getAttribute(PDO::ATTR_SERVER_VERSION), '5.7.8', 'ge')
-            ? 'json' : 'text';
+        $driverName = DB::connection()->getPdo()->getAttribute(PDO::ATTR_DRIVER_NAME);
+        $dbVersion = DB::connection()->getPdo()->getAttribute(PDO::ATTR_SERVER_VERSION);
+        $isOldVersion = version_compare($dbVersion, '5.7.8', 'lt');
+
+        return $driverName === 'mysql' && $isOldVersion ? 'text' : 'json';
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -53,8 +53,10 @@ public function down(): void`
`53`	`53`	`*/`
`54`	`54`	`protected function jsonable(): string`
`55`	`55`	`{`
`56`		`- return DB::connection()->getPdo()->getAttribute(PDO::ATTR_DRIVER_NAME) === 'mysql'`
`57`		`- && version_compare(DB::connection()->getPdo()->getAttribute(PDO::ATTR_SERVER_VERSION), '5.7.8', 'ge')`
`58`		`- ? 'json' : 'text';`
	`56`	`+ $driverName = DB::connection()->getPdo()->getAttribute(PDO::ATTR_DRIVER_NAME);`
	`57`	`+ $dbVersion = DB::connection()->getPdo()->getAttribute(PDO::ATTR_SERVER_VERSION);`
	`58`	`+ $isOldVersion = version_compare($dbVersion, '5.7.8', 'lt');`
	`59`	`+`
	`60`	`+ return $driverName === 'mysql' && $isOldVersion ? 'text' : 'json';`
`59`	`61`	`}`
`60`	`62`	`}`
Original file line number	Diff line number	Diff line change
`@@ -49,8 +49,10 @@ public function down()`
`49`	`49`	`*/`
`50`	`50`	`protected function jsonable(): string`
`51`	`51`	`{`
`52`		`- return DB::connection()->getPdo()->getAttribute(PDO::ATTR_DRIVER_NAME) === 'mysql'`
`53`		`- && version_compare(DB::connection()->getPdo()->getAttribute(PDO::ATTR_SERVER_VERSION), '5.7.8', 'ge')`
`54`		`- ? 'json' : 'text';`
	`52`	`+ $driverName = DB::connection()->getPdo()->getAttribute(PDO::ATTR_DRIVER_NAME);`
	`53`	`+ $dbVersion = DB::connection()->getPdo()->getAttribute(PDO::ATTR_SERVER_VERSION);`
	`54`	`+ $isOldVersion = version_compare($dbVersion, '5.7.8', 'lt');`
	`55`	`+`
	`56`	`+ return $driverName === 'mysql' && $isOldVersion ? 'text' : 'json';`
`55`	`57`	`}`
`56`	`58`	`}`