test fix and small improvements

Author: Ricardo Fiorani

src/Adapter/Vimeo/VimeoServiceAdapter.php

@@ -228,7 +228,7 @@ public function isEmbeddable()
      *
      * @todo make this better by using guzzle
      *
-     * @return array
+     * @return \stdClass
      *
      * @throws ServiceApiNotAvailable
      */

src/Container/ServicesContainer.php

@@ -1,10 +1,5 @@
 <?php
-/**
- * Created by PhpStorm.
- * User: Ricardo Fiorani
- * Date: 31/08/2015
- * Time: 21:06.
- */
+
 namespace RicardoFiorani\Container;
 
 use RicardoFiorani\Adapter\CallableServiceAdapterFactoryInterface;
@@ -68,14 +63,15 @@ private function registerFromConfig(array $config)
         foreach ($config['services'] as $serviceName => $serviceConfig) {
             $this->registerService($serviceName, $serviceConfig['patterns'], $serviceConfig['factory']);
         }
+
         $this->setRenderer($config['renderer']['name'], $config['renderer']['factory']);
     }
 
     /**
      * Register a Service.
      *
-     * @param string          $serviceName
-     * @param array           $regex
+     * @param string $serviceName
+     * @param array $regex
      * @param string|callable $factory
      *
      * @throws DuplicatedServiceNameException
@@ -84,7 +80,10 @@ public function registerService($serviceName, array $regex, $factory)
     {
         if ($this->hasService($serviceName)) {
             throw new DuplicatedServiceNameException(
-                'The service "%s" is already registered in the container.', $serviceName
+                sprintf(
+                    'The service "%s" is already registered in the container.',
+                    $serviceName
+                )
             );
         }
 

test/Container/ServicesContainerTest.php

@@ -1,14 +1,7 @@
 <?php
-/**
- * Created by PhpStorm.
- * User: Ricardo Fiorani
- * Date: 10/02/2016
- * Time: 19:58
- */
 
 namespace RicardoFiorani\Test\Container;
 
-
 use PHPUnit_Framework_TestCase;
 use RicardoFiorani\Container\ServicesContainer;
 use stdClass;
@@ -31,8 +24,11 @@ public function testServiceContainerServiceRegistrationByInjection()
         });
 
         $this->assertContains('TestService', $serviceContainer->getServiceNameList());
+
         $this->setExpectedException('\\RicardoFiorani\\Container\\Exception\\DuplicatedServiceNameException');
+
         $serviceContainer->registerService('TestService', array('#testPattern#'), function () {
+            // @todo test the injected service maybe ?
         });
     }
 
@@ -44,14 +40,15 @@ public function testServicesList()
         $this->assertContains('Youtube', $serviceContainer->getServices());
     }
 
-    public function testIfReturnsAlreadyInstantiatedFactory(){
+    public function testIfReturnsAlreadyInstantiatedFactory()
+    {
         $config = $this->getMockConfig();
         $serviceContainer = $this->createServiceContainer($config);
         $factory = $serviceContainer->getFactory('Youtube');
-        $this->assertInstanceOf('\\RicardoFiorani\\Adapter\\Youtube\\Factory\\YoutubeServiceAdapterFactory',$factory);
+        $this->assertInstanceOf('\\RicardoFiorani\\Adapter\\Youtube\\Factory\\YoutubeServiceAdapterFactory', $factory);
 
         $alreadyInstantiatedFactory = $serviceContainer->getFactory('Youtube');
-        $this->assertEquals($factory,$alreadyInstantiatedFactory);
+        $this->assertEquals($factory, $alreadyInstantiatedFactory);
     }
 
     /**