Fix rewatch panic on duplicate module name (#8102)

* Fix rewatch panic on duplicate module name

* Deterministic order of file/module names in error message

* Update rewatch/src/build/packages.rs

Co-authored-by: Florian Verdonck <[email protected]>

* Fix snapshot

* Move cloning root_path into error handling code

* CHANGELOG

---------

Co-authored-by: Florian Verdonck <[email protected]>

Author: cknitt

CHANGELOG.md

@@ -26,6 +26,7 @@
 - Fix: do not warn for "editor" field in `rescript.json`. https://github.com/rescript-lang/rescript/pull/8084
 - Fix `@val` shadowing (rewrite using `globalThis`). https://github.com/rescript-lang/rescript/pull/8098
 - Fix `@scope` shadowing (rewrite using `globalThis`). https://github.com/rescript-lang/rescript/pull/8100
+- Fix rewatch panic on duplicate module name. https://github.com/rescript-lang/rescript/pull/8102
 
 #### :memo: Documentation
 

rewatch/src/build.rs

@@ -147,7 +147,7 @@ pub fn initialize_build(
     }
 
     let mut build_state = BuildCommandState::new(project_context, packages, compiler, warn_error);
-    packages::parse_packages(&mut build_state);
+    packages::parse_packages(&mut build_state)?;
 
     let compile_assets_state = read_compile_state::read(&mut build_state)?;
 

rewatch/src/build/clean.rs

@@ -366,7 +366,7 @@ pub fn clean(path: &Path, show_progress: bool, plain_output: bool) -> Result<()>
 
     let timing_clean_mjs = Instant::now();
     let mut build_state = BuildState::new(project_context, packages, compiler_info);
-    packages::parse_packages(&mut build_state);
+    packages::parse_packages(&mut build_state)?;
     let root_config = build_state.get_root_config();
     let suffix_for_print = match root_config.package_specs {
         None => match &root_config.suffix {