From ad5885756af453ada7586644e2b91d3a04fdfd3a Mon Sep 17 00:00:00 2001 From: remorses Date: Tue, 24 Jun 2025 11:35:58 +0200 Subject: [PATCH 1/4] Do not add condition "module" in Vitest environment --- packages/react-router-dev/vite/plugin.ts | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/packages/react-router-dev/vite/plugin.ts b/packages/react-router-dev/vite/plugin.ts index 3905414211..52d5377147 100644 --- a/packages/react-router-dev/vite/plugin.ts +++ b/packages/react-router-dev/vite/plugin.ts @@ -3462,8 +3462,16 @@ export async function getEnvironmentOptionsResolvers( `file:///${path.join(packageRoot, "module-sync-enabled/index.mjs")}` ); let vite = getVite(); + let defaultServerConditions = vite.defaultServerConditions ?? []; + if (process.env.VITEST) { + // Vitest will fail to import packages that distribute invalid ESM if the condition "module" is added: https://github.com/remix-run/react-router/issues/13869 + defaultServerConditions = defaultServerConditions.filter( + (condition) => condition !== "module" + ); + } + let viteServerConditions: string[] = [ - ...(vite.defaultServerConditions ?? []), + ...defaultServerConditions, ...(moduleSyncEnabled ? ["module-sync"] : []), ]; From d0b2a24270b1d775e10dbd74b85aa01021339325 Mon Sep 17 00:00:00 2001 From: remorses Date: Tue, 24 Jun 2025 11:38:58 +0200 Subject: [PATCH 2/4] Update contributors.yml --- contributors.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/contributors.yml b/contributors.yml index f7cc03ee2c..8c3019d8ca 100644 --- a/contributors.yml +++ b/contributors.yml @@ -402,3 +402,4 @@ - zeromask1337 - zheng-chuang - zxTomw +- remorses From 61abe17738d4f820f471ddfccd7c45ec1f844480 Mon Sep 17 00:00:00 2001 From: remorses Date: Tue, 24 Jun 2025 11:39:50 +0200 Subject: [PATCH 3/4] Create lemon-buckets-matter.md --- .changeset/lemon-buckets-matter.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/lemon-buckets-matter.md diff --git a/.changeset/lemon-buckets-matter.md b/.changeset/lemon-buckets-matter.md new file mode 100644 index 0000000000..b54bc97bf5 --- /dev/null +++ b/.changeset/lemon-buckets-matter.md @@ -0,0 +1,5 @@ +--- +"@react-router/dev": patch +--- + +Do not use "module" condition when running Vitest tests From 86c617304cef8219338990e89fe65b62d5b78beb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20De=20Boey?= Date: Wed, 25 Jun 2025 23:11:46 +0200 Subject: [PATCH 4/4] Update .changeset/lemon-buckets-matter.md --- .changeset/lemon-buckets-matter.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/lemon-buckets-matter.md b/.changeset/lemon-buckets-matter.md index b54bc97bf5..9aa52eab6c 100644 --- a/.changeset/lemon-buckets-matter.md +++ b/.changeset/lemon-buckets-matter.md @@ -2,4 +2,4 @@ "@react-router/dev": patch --- -Do not use "module" condition when running Vitest tests +Don't use `"module"` server conditions in Vitest