Skip to content

Commit c978b25

Browse files
committed
Add note on minimal reproductions to governance doc
1 parent a842447 commit c978b25

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

GOVERNANCE.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ In order to reduce friction the SC will primarily operate asynchronously via Git
5252

5353
Due to the # of React Router applications out there, we have to be a bit strict on the process for filing issues to avoid an overload in Github.
5454

55-
- **All** bugs must have a **minimal** reproduction
55+
- **All** bugs must have a **minimal** reproduction [^3]
5656
- Minimal means that it is not just pointing to a deployed site or a branch in your existing application
5757
- The preferred method is StackBlitz via [https://reactrouter.com/new](https://reactrouter.com/new)
5858
- If Stackblitz is not an option, a Github repo based on a fresh `create-react-router` app is acceptable
@@ -66,9 +66,11 @@ Due to the # of React Router applications out there, we have to be a bit strict
6666
- These issues will generally be ones that are likely to have a small surface area fix
6767
- However, anyone can work on any issue but there's no guarantee the PR will be accepted if the surface area is too large for expedient review by a core team member
6868

69+
[^3]: https://antfu.me/posts/why-reproductions-are-required
70+
6971
## New Feature Process
7072

71-
The process for new features being added to React Router will follow a series of stages loosely based on the [TC39 Process](https://tc39.es/process-document/). It is important to note that entrance into any given stage does not imply that an RFC will proceed any further. The stages will act as a funnel with fewer and fewer RFCs making it into subsequent stages such that only the strongest RFCs make it into a React Router release in a stable fashion. This table gives a high-level overview of the Stages but please see the individual stage sections below for more detailed information on the stages and the process for moving an FC through them.
73+
The process for new features being added to React Router will follow a series of stages loosely based on the [TC39 Process](https://tc39.es/process-document/). It is important to note that entrance into any given stage does not imply that an RFC will proceed any further. The stages will act as a funnel with fewer RFCs making it into subsequent stages such that only the strongest RFCs make it into a React Router release in a stable fashion. This table gives a high-level overview of the Stages but please see the individual stage sections below for more detailed information on the stages and the process for moving an FC through them.
7274

7375
| Stage | Name | Entrance Criteria | Purpose |
7476
| ----- | ------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |

0 commit comments

Comments
 (0)