test: temporarily ignore hmr port error for custom servers

Author: pcattori

.tests/test.netlify.ts

@@ -1,7 +1,12 @@
 import { expect, Page } from "@playwright/test";
 import getPort from "get-port";
 
-import { matchLine, testTemplate, urlRegex } from "./utils";
+import {
+  matchLine,
+  testTemplate,
+  urlRegex,
+  withoutHmrPortError,
+} from "./utils";
 
 const test = testTemplate("netlify");
 
@@ -15,7 +20,7 @@ test("dev", async ({ page, $ }) => {
 
   const url = await matchLine(dev.stdout, urlRegex.custom);
   await workflow({ page, url });
-  expect(dev.buffer.stderr).toBe("");
+  expect(withoutHmrPortError(dev.buffer.stderr)).toBe("");
 });
 
 test("build", async ({ $ }) => {

.tests/test.node-custom-server.ts

@@ -1,7 +1,12 @@
 import { expect, Page } from "@playwright/test";
 import getPort from "get-port";
 
-import { matchLine, testTemplate, urlRegex } from "./utils";
+import {
+  matchLine,
+  testTemplate,
+  urlRegex,
+  withoutHmrPortError,
+} from "./utils";
 
 const test = testTemplate("node-custom-server");
 
@@ -15,7 +20,8 @@ test("dev", async ({ page, $ }) => {
 
   const url = await matchLine(dev.stdout, urlRegex.custom);
   await workflow({ page, url });
-  expect(dev.buffer.stderr).toBe("");
+
+  expect(withoutHmrPortError(dev.buffer.stderr)).toBe("");
 });
 
 test("build + start", async ({ page, $ }) => {

.tests/test.vercel.ts

@@ -1,7 +1,12 @@
 import { expect, Page } from "@playwright/test";
 import getPort from "get-port";
 
-import { matchLine, testTemplate, urlRegex } from "./utils";
+import {
+  matchLine,
+  testTemplate,
+  urlRegex,
+  withoutHmrPortError,
+} from "./utils";
 
 const test = testTemplate("vercel");
 
@@ -15,7 +20,7 @@ test("dev", async ({ page, $ }) => {
 
   const url = await matchLine(dev.stdout, urlRegex.custom);
   await workflow({ page, url });
-  expect(dev.buffer.stderr).toBe("");
+  expect(withoutHmrPortError(dev.buffer.stderr)).toBe("");
 });
 
 test("build", async ({ $ }) => {

.tests/utils.ts

@@ -143,3 +143,10 @@ export const urlRegex = {
   netlify: urlMatch({ prefix: /◈ Server now ready on / }),
   wrangler: urlMatch({ prefix: /Ready on / }),
 };
+
+// `vite.createServer` always tries to use the same HMR port
+// unless `server.hmr.port` is configured.
+// Ultimately, we should provide better primitives for building custom servers
+// something like `createRequestHandler(pathToBuild)`.
+export const withoutHmrPortError = (stderr: string) =>
+  stderr.replace(/WebSocket server error: Port is already in use/, "").trim();