Skip to content

Commit 2811649

Browse files
glenjaminmarkerikson
authored andcommitted
Fix up scripts and dependencies and things (#15)
* Fix merge conflict markers in react bundle * Set fps-emit back to `src`, `lib` doesn't exist * Install some missing dependencies * Update README instructions for fps-emit * Update all package-lock.json files Due to https://npm.community/t/754 these had to be rebuilt to get the file:../../fps-emit package install to work * Update benchmark versions to latest v5 and v6 * Switch from NPM to Yarn * Use weighted average FPS * Fix up README
1 parent 535f498 commit 2811649

24 files changed

+30257
-58138
lines changed

README.md

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,50 +1,52 @@
11
# react-redux-benchmarks
22
Performance benchmark harness for React-Redux
33

4+
This repo expects that you are using Yarn for package management.
5+
46
# Running benchmarks
57
```bash
6-
npm run initialize
7-
npm start
8+
yarn initialize
9+
yarn start
810
```
911

1012
After benchmarks have been initialized, you can run with simply:
1113

1214
```bash
13-
npm start
15+
yarn start
1416
```
1517

1618
## Running specific versions
1719

1820
To specify a single version:
1921

2022
```bash
21-
REDUX=5.0.7 npm start
23+
REDUX=5.0.7 yarn start
2224
```
2325

2426
To specify running against multiple versions:
2527

2628
```bash
27-
REDUX=5.0.7:4.4.9 npm start
29+
REDUX=5.0.7:4.4.9 yarn start
2830
```
2931

3032
To run a specific benchmark:
3133

3234
```bash
33-
BENCHMARKS=stockticker npm start
35+
BENCHMARKS=stockticker yarn start
3436
```
3537

3638
or specific benchmarks:
3739

3840
```bash
39-
BENCHMARKS=stockticker:another npm start
41+
BENCHMARKS=stockticker:another yarn start
4042
```
4143

4244
## Setting run length
4345

4446
By default, benchmarks run for 30 seconds. To change this, use
4547

4648
```bash
47-
SECONDS=10 npm start
49+
SECONDS=10 yarn start
4850
```
4951

5052

@@ -69,7 +71,6 @@ module.exports = function override(config, env) {
6971
"react" : "React",
7072
"redux" : "Redux",
7173
"react-redux" : "ReactRedux",
72-
"fps-emit": "FpsEmit",
7374
}
7475
}
7576

@@ -94,6 +95,6 @@ Also, `index.html` must be modified to include these lines:
9495
```html
9596
<script type="text/javascript" src="redux.min.js"></script>
9697
<script type="text/javascript" src="react.production.min.js"></script>
98+
<script type="text/javascript" src="react-dom.production.min.js"></script>
9799
<script type="text/javascript" src="react-redux.min.js"></script>
98-
<script type="text/javascript" src="fps-emit.min.js"></script>
99-
```
100+
```

copy-to-public/react.production.min.js

Lines changed: 1 addition & 22 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)