Skip to content

Include design considerations in README #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mojodna opened this issue Sep 17, 2010 · 4 comments
Closed

Include design considerations in README #1

mojodna opened this issue Sep 17, 2010 · 4 comments
Labels

Comments

@mojodna
Copy link

mojodna commented Sep 17, 2010

Why would I want to use this instead of fictorial's lib? What differences are there (philosophical, primarily; I'd assume that the API differs)?

@mranney
Copy link
Contributor

mranney commented Sep 17, 2010

Yeah, I agree. This needs to be documented more clearly.

The API for basic commands is identical. The primary difference is that this one works in the latest versions of node, and this one is published in npm.

@mranney
Copy link
Contributor

mranney commented Sep 17, 2010

I've updated the README. Does that address your concern?

@mojodna
Copy link
Author

mojodna commented Sep 17, 2010

Yes, that's super-helpful. I'm still curious about the high-level decisions that make it fast, but the fact that the README now acknowledges other options and includes differentiators is huge.

@mranney
Copy link
Contributor

mranney commented Sep 17, 2010

I'm not entirely sure about all the sources of speed gain. I hand-rolled a byte-at-a-time parser, and have special optimizations for small replies.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants