[Bug]: Refit Trimming double quotes from the end of the query string

[baynezy]

Describe the bug 🐞

I have a previously working integration with Auth0:

[Get("/users?q=app_metadata.profileId:\"{profileId}\"")]
Task<IApiResponse<List<Auth0User>>> GetUsersByProfileIdAsync(string profileId, CancellationToken ct);

With version 8.0.0 this worked perfectly. When I upgrade to 9.0.2 then it trims the final " from the end of the URL.

Step to reproduce

1. Create a project with Refit 8.0.0
2. Create a Refit API call that has a double quote on the end of the query string
3. Execute the code and note the URL that is called
4. Update the project to Refit 9.0.2
5. Execute the code again and compare the URL to the previous one

Reproduction repository

No response

Expected behavior

Trailing double quotes should not be removed.

Screenshots 🖼️

No response

IDE

Rider Windows

Operating system

Windows

Version

11

Device

No response

Refit Version

9.0.2

Additional information ℹ️

No response

[auptonmercuria]

Does the fix also resolve and issue with trailing slashes on the URI? e.g. https://github.com/reactiveui/refit/pull/ is getting modified to https://github.com/reactiveui/refit/pull which now fails on some sites? The new test doesn't appear, at first sight, to cover this issue.

GitHub

Pull requests · reactiveui/refit

The automatic type-safe REST library for .NET Core, Xamarin and .NET. Heavily inspired by Square's Retrofit library, Refit turns your REST API into a live interface. - Pull requests · reactiveu...

GitHub

Pull requests · reactiveui/refit

The automatic type-safe REST library for .NET Core, Xamarin and .NET. Heavily inspired by Square's Retrofit library, Refit turns your REST API into a live interface. - Pull requests · reactiveu...

[baynezy]

@auptonmercuria I think you've pasted in incorrect links above. They just go straight to the list of all pull requests on this repository.

The bug I'm fixing is that the code currently removes the last character of the URL template if there are characters after the last parameter.

I'm happy to add more test coverage if you'd like.

[auptonmercuria]

Apologies I didn't go back enough when paging back after looking at the tests. I think it would be good to add a test for the specific instance we are seeing happy to add tests and do a PR if necessary) as the current test only looks for a substring without a trailing slash. They are treated as different requests by some API writers. We are now getting a 404 which we working around by adding a {foo} extra parameter after the space to stop it being stripped out.

i.e. if we have

[Get("/profiles/{profileId}/")]
Task<Profile> GetProfile(int profileId);

We expect the trailing / to be respected as '/profiles/101/'

[baynezy]

@auptonmercuria - I have added more test coverage and improved the code around the fix.

NOTE - all existing tests still pass. So there should be no regressions

[auptonmercuria]

@baynezy Thanks, much appreciated! Have a good weekend.