RNTester: update iOS icon, support dark mode in LaunchScreen#53920
Closed
Simek wants to merge 2 commits into
Closed
RNTester: update iOS icon, support dark mode in LaunchScreen#53920Simek wants to merge 2 commits into
Simek wants to merge 2 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-bot
added
p: Expo
Contributor
|
I think it would be nice if we could add a little grid in the background an align it to the Android app icon: 
|
Collaborator
Author
|
@cortinico I have updated the icon assets to include the grid, LMK if this looks/feels better. 
|
Contributor
Yup that's so much better 🙏 |
Collaborator
|
This PR is stale because it has been open for 180 days with no activity. It will be closed in 7 days unless you comment on it or remove the "Stale" label. |
react-native-bot
added
the
Stale
Collaborator
|
This PR was closed because it has been stalled for 7 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Spotted that RNTester iOS app icon still used the old React logo, so I have updated it. I decided not to use Icon Composer format/file yet to do not introduce issues for those on older Xcode version, but we should explore migrating to that format in the future, refs:
Additionally, I have updated the LaunchScreen storyboard elements colors, so instead custom one, they use now system colors which supports theming out of the box.
Changelog:
[INTERNAL][CHANGED] - Update iOS RNTester app icon, add theme support to LaunchScreen
Test Plan:
The changes have been verified in Xcode and tested by running RNTester on real device.
Preview