Skip to content

Commit b11dbea

Browse files
authored
fix: remove deprecated warning of clearIcon (#970)
1 parent 2879b2c commit b11dbea

File tree

2 files changed

+0
-11
lines changed

2 files changed

+0
-11
lines changed

src/BaseSelect.tsx

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ import TransBtn from './TransBtn';
1919
import { getSeparatedContent } from './utils/valueUtil';
2020
import type { DisplayInfoType, DisplayValueType, Mode, Placement, RenderDOMFunc, RenderNode, RawValueType } from './interface';
2121
import { useAllowClear } from './hooks/useAllowClear';
22-
import { warning } from 'rc-util';
2322

2423
export type { DisplayInfoType, DisplayValueType, Mode, Placement, RenderDOMFunc, RenderNode, RawValueType };
2524

@@ -684,12 +683,6 @@ const BaseSelect = React.forwardRef((props: BaseSelectProps, ref: React.Ref<Base
684683
}
685684

686685
// ============================= Clear ==============================
687-
if (process.env.NODE_ENV !== 'production') {
688-
warning(
689-
!props.clearIcon,
690-
'`clearIcon` will be removed in future. Please use `allowClear` instead.',
691-
);
692-
}
693686
const onClearMouseDown: React.MouseEventHandler<HTMLSpanElement> = () => {
694687
onClear?.();
695688

tests/Select.test.tsx

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,6 @@ describe('Select.Basic', () => {
286286

287287

288288
resetWarned();
289-
const errSpy = jest.spyOn(console, 'error').mockImplementation(() => {});
290289
const wrapper5 = mount(
291290
<Select allowClear clearIcon={<div className='custom-clear-icon'>x</div>} value="1">
292291
<Option value="1">1</Option>
@@ -295,9 +294,6 @@ describe('Select.Basic', () => {
295294
);
296295
expect(wrapper5.find('.custom-clear-icon').length).toBeTruthy();
297296
expect(wrapper5.find('.custom-clear-icon').text()).toBe('x');
298-
expect(errSpy).toHaveBeenCalledWith(
299-
'Warning: `clearIcon` will be removed in future. Please use `allowClear` instead.'
300-
);
301297

302298
const wrapper6 = mount(
303299
<Select allowClear clearIcon={<div className='custom-clear-icon'>x</div>}>

0 commit comments

Comments
 (0)