Skip to content

Commit 6eb85a6

Browse files
committed
Fix unexpected onSearch call
close ant-design/ant-design#10817
1 parent 37700fc commit 6eb85a6

File tree

2 files changed

+19
-1
lines changed

2 files changed

+19
-1
lines changed

src/Select.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -669,7 +669,7 @@ class Select extends React.Component {
669669
};
670670
// clear search input value when open is false in singleMode.
671671
if (!open && isSingleMode(props) && props.showSearch) {
672-
this.setInputValue('');
672+
this.setInputValue('', false);
673673
}
674674
if (!open) {
675675
this.maybeFocus(open, needFocus);

tests/Select.spec.js

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -350,6 +350,24 @@ describe('Select', () => {
350350
expect(handleSearch).not.toBeCalled();
351351
});
352352

353+
// https://github.com/ant-design/ant-design/issues/10817
354+
it('not fires extra search event when user search and select', () => {
355+
const handleSearch = jest.fn();
356+
const wrapper = mount(
357+
<Select
358+
showSearch
359+
onSearch={handleSearch}
360+
>
361+
<Option value="1">1</Option>
362+
<Option value="2">2</Option>
363+
</Select>
364+
);
365+
wrapper.find('input').simulate('change', { target: { value: '1' } });
366+
wrapper.find('MenuItem').first().simulate('click');
367+
expect(handleSearch).toHaveBeenCalledTimes(1);
368+
});
369+
370+
353371
describe('focus', () => {
354372
let handleFocus;
355373
let wrapper;

0 commit comments

Comments
 (0)