🐛 Fix Cascader title cannot be reset to empty

close ant-design/ant-design#18713

Author: afc163

package.json

@@ -1,6 +1,6 @@
 {
   "name": "rc-cascader",
-  "version": "0.17.4",
+  "version": "0.17.5",
   "description": "cascade select ui component for react",
   "keywords": [
     "react",

src/Menus.jsx

@@ -62,8 +62,9 @@ class Menus extends React.Component {
       menuItemCls += ` ${prefixCls}-menu-item-loading`;
       loadingIconNode = loadingIcon || null;
     }
+
     let title = '';
-    if (option.title) {
+    if ('title' in option) {
       title = option.title;
     } else if (typeof option[this.getFieldName('label')] === 'string') {
       title = option[this.getFieldName('label')];

tests/__snapshots__/index.spec.js.snap

@@ -0,0 +1,52 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`Cascader should not show title when title is falsy 1`] = `
+<ul
+  className="rc-cascader-menu"
+  key="0"
+>
+  <li
+    className="rc-cascader-menu-item"
+    key="1"
+    onClick={[Function]}
+    onDoubleClick={[Function]}
+    onMouseDown={[Function]}
+    role="menuitem"
+    title=""
+  >
+    1
+  </li>
+  <li
+    className="rc-cascader-menu-item"
+    key="2"
+    onClick={[Function]}
+    onDoubleClick={[Function]}
+    onMouseDown={[Function]}
+    role="menuitem"
+  >
+    2
+  </li>
+  <li
+    className="rc-cascader-menu-item"
+    key="3"
+    onClick={[Function]}
+    onDoubleClick={[Function]}
+    onMouseDown={[Function]}
+    role="menuitem"
+    title="3"
+  >
+    3
+  </li>
+  <li
+    className="rc-cascader-menu-item"
+    key="4"
+    onClick={[Function]}
+    onDoubleClick={[Function]}
+    onMouseDown={[Function]}
+    role="menuitem"
+    title="title"
+  >
+    4
+  </li>
+</ul>
+`;

tests/index.spec.js

@@ -562,4 +562,36 @@ describe('Cascader', () => {
     expect(onFocus).toHaveBeenCalledTimes(1);
     expect(onBlur).toHaveBeenCalledTimes(0);
   });
+
+  // https://github.com/ant-design/ant-design/issues/18713
+  it('should not show title when title is falsy', () => {
+    const options = [
+      {
+        value: '1',
+        label: '1',
+        title: '',
+      },
+      {
+        value: '2',
+        label: '2',
+        title: undefined,
+      },
+      {
+        value: '3',
+        label: '3',
+      },
+      {
+        value: '4',
+        label: '4',
+        title: 'title',
+      },
+    ];
+    const wrapper = mount(
+      <Cascader options={options} popupVisible>
+        <input readOnly />
+      </Cascader>,
+    );
+    const menus = wrapper.find('.rc-cascader-menu');
+    expect(menus).toMatchSnapshot();
+  });
 });