Skip to content

LinkContainer turns all children's tags into a's. #261

Open
@dennisoelkers

Description

@dennisoelkers

We are currently upgrading from react-router v3 to v5, therefore also upgrading react-router-bootstrap from v0.23.3 to v0.25.0. We have noticed that LinkContainer (which is just wrapping Route) is turning all children into a-tags, even though e.g. a Button component is passed.

Is this on purpose? Is there any way around this?

Right now it is breaking our tests (we are assuming e.g. that a button component is used in some places).

Activity

antoHuman

antoHuman commented on Oct 21, 2022

@antoHuman

This is something that I expect, as it works well with react bootstrap Button component. The final element is an anchor a with the style of a button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      `LinkContainer` turns all children's tags into `a`'s. · Issue #261 · react-bootstrap/react-router-bootstrap