Skip to content

tagName is undefined #132

Open
Open
@grydstedt

Description

@grydstedt

The siblings crawl done by the modal manager crashes sometimes in Safari.
Scripts and libraries will add all sort of stuff into the body and by default the modal manager will use the body as container. This sometimes ends up crashing in safari.

Specfically:
let isHidable = ({ nodeType, tagName }) => nodeType === 1 && BLACKLIST.indexOf(tagName.toLowerCase()) === -1;

tagName here is undefined sometimes. Also trying to access siblings like cross-origin iframes will throw a security error. Perhaps we can check if tagName is defined here?

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions