-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Update domainr extension #23984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update domainr extension #23984
Conversation
|
Thank you for your contribution! 🎉 🔔 @rawnly @xmok @chrismessina you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. 📋 Quick checkout commandsBRANCH="ext/domainr"
FORK_URL="https://github.com/c1vk/raycast-extensions.git"
EXTENSION_NAME="domainr"
REPO_NAME="raycast-extensions"
git clone -n --depth=1 --filter=tree:0 -b $BRANCH $FORK_URL
cd $REPO_NAME
git sparse-checkout set --no-cone "extensions/$EXTENSION_NAME"
git checkout
cd "extensions/$EXTENSION_NAME"
npm install && npm run devDue to our current reduced availability, the initial review may take up to 10-15 business days. |
Greptile SummaryUpdated extension title from "Domainr (Fastly Domain Search)" to "Fastly Domain Search (formerly Domainr)" to reflect Fastly's 2023 acquisition of Domainr. The change is purely cosmetic and affects the extension title and command subtitle in
Confidence Score: 5/5
Important Files Changed
|
Greptile's behavior is changing!From now on, if a review finishes with no comments, we will not post an additional "statistics" comment to confirm that our review found nothing to comment on. However, you can confirm that we reviewed your changes in the status check section. This feature can be toggled off in your Code Review Settings by deselecting "Create a status check for each PR". |
extensions/domainr/CHANGELOG.md
Outdated
|
|
||
| ## [Unreleased] - {PR_MERGE_DATE} | ||
|
|
||
| - Renamed "Domainr (Fastly Domain Search)" to "Fastly Domain Search (formerly Domainr)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please just use "Fastly Domain Search".
extensions/domainr/package.json
Outdated
| "$schema": "https://www.raycast.com/schemas/extension.json", | ||
| "name": "domainr", | ||
| "title": "Domainr (Fastly Domain Search)", | ||
| "title": "Fastly Domain Search (formerly Domainr)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "title": "Fastly Domain Search (formerly Domainr)", | |
| "title": "Fastly Domain Search", |
extensions/domainr/package.json
Outdated
| "name": "domainr", | ||
| "title": "Search Domain", | ||
| "subtitle": "Domainr (Fastly Domain Search)", | ||
| "subtitle": "Fastly Domain Search (formerly Domainr)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "subtitle": "Fastly Domain Search (formerly Domainr)", | |
| "subtitle": "Fastly Domain Search", |
|
As mentioned here, let's move to the cleaner "Fastly Domain Search" everywhere; it's been three years since Fastly acquired Domainr. @c1vk the README already clarifies that this extension was FKA as Domainr. |
|
Sure @chrismessina — I’ll update the pull request with these changes. |
|
Hi @chrismessina, |
Description
Renamed the extension title to "Fastly Domain Search (formerly Domainr)"
This change addresses the naming concern raised in #23973 and does not affect functionality or behavior of the extension.
Closes #23973
Screencast
Before
After
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare placed outside of themetadatafolder