Skip to content

[Feature] REP 54: Implement the HeadReady condition #2237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
rueian opened this issue Jul 11, 2024 · 3 comments
Closed
2 tasks done

[Feature] REP 54: Implement the HeadReady condition #2237

rueian opened this issue Jul 11, 2024 · 3 comments
Assignees
Labels

Comments

@rueian
Copy link
Contributor

rueian commented Jul 11, 2024

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

This is one of the tracking items of the REP: RayCluster status improvement, the step 5 in the design doc: https://docs.google.com/document/d/1bRL0cZa87eCX6SI7gqthN68CgmHaB6l3-vJuIse-BrY

We should implement the new HeadReady condition by referring to the current utils.IsRunningAndReady

func (r *RayServiceReconciler) isHeadPodRunningAndReady(ctx context.Context, instance *rayv1.RayCluster) (bool, error) {
headPod, err := r.getHeadPod(ctx, instance)
if err != nil {
return false, err
}
return utils.IsRunningAndReady(headPod), nil
}

Once the condition is implemented, we should base on it to refactor the isHeadPodRunningAndReady function.

Use case

No response

Related issues

ray-project/enhancements#54

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@rueian
Copy link
Contributor Author

rueian commented Jul 12, 2024

Hi @cchen777, would you like to take on this?

@cchen777
Copy link
Contributor

yes @rueian i'd like to take on this !

@kevin85421
Copy link
Member

Closes #2261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants