Skip to content

[Feature] REP 54: Don’t assign the rayv1.Failed to the State field #2234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks done
rueian opened this issue Jul 11, 2024 · 2 comments · Fixed by #2258
Closed
2 tasks done

[Feature] REP 54: Don’t assign the rayv1.Failed to the State field #2234

rueian opened this issue Jul 11, 2024 · 2 comments · Fixed by #2258
Assignees
@rueian
Labels
1.2.0 crd-observability enhancement New feature or request

Comments

@rueian
Copy link
Contributor

rueian commented Jul 11, 2024

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

This is one of the tracking items of the REP: RayCluster status improvement, the step 2 in the design doc: https://docs.google.com/document/d/1bRL0cZa87eCX6SI7gqthN68CgmHaB6l3-vJuIse-BrY

We should stop writing the rayv1.Failed to the .Status.State field if the RayClusterStatusConditions feature gate is enabled.

Use case

No response

Related issues

ray-project/enhancements#54
#2219

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@rueian rueian added enhancement New feature or request triage labels Jul 11, 2024
@rueian rueian changed the title [Feature] REP 54: Don’t assign the rayv1.Failed to the State field if the feature gate is enabled [Feature] REP 54: Don’t assign the rayv1.Failed to the State field Jul 11, 2024
@rueian
Copy link
Contributor Author

rueian commented Jul 11, 2024

Hi @Yicheng-Lu-llll, would you like to take this one?

@Yicheng-Lu-llll
Copy link
Contributor

sure

@Yicheng-Lu-llll Yicheng-Lu-llll mentioned this issue Jul 19, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rueian rueian

Labels
1.2.0 crd-observability enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don’t assign the rayv1.Failed to the State field Yicheng-Lu-llll/kuberay
3 participants
@rueian @kevin85421 @Yicheng-Lu-llll