Reduce instantiations of Reduction kernels
#2679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
divyegala
added
improvement
robertmaynard
approved these changes
Jun 2, 2025
cjnolet
approved these changes
Jun 5, 2025
Member
|
Looks good, and I'm glad it's marked breaking. Will just need to check w/ cuML and cuVS (and maybe cuGraph and/or cuOpt)? |
Member
Author
|
/merge |
rapids-bot bot
pushed a commit
to rapidsai/cuvs
that referenced
this pull request
Jun 12, 2025
Depends on rapidsai/raft#2679 with reference issue rapidsai/raft#2681. This PR reduces the wheel size from 936.9 MB to 917.1 MB. Authors: - Divye Gala (https://github.com/divyegala) - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Robert Maynard (https://github.com/robertmaynard) - Corey J. Nolet (https://github.com/cjnolet) - Mike Sarahan (https://github.com/msarahan) - https://github.com/jakirkham URL: #925
rapids-bot bot
pushed a commit
to rapidsai/cuml
that referenced
this pull request
Jun 12, 2025
Depends on rapidsai/raft#2679, https://github.com/rapidsai/cumlprims_mg/pull/263, and rapidsai/cuvs#925 with reference issue rapidsai/raft#2681. This reduces the CUDA 12 binary size of `libcuml++.so`by 11 MB from ~286 MB to ~275 MB. Authors: - Divye Gala (https://github.com/divyegala) Approvers: - Robert Maynard (https://github.com/robertmaynard) - Dante Gama Dessavre (https://github.com/dantegd) - Mike Sarahan (https://github.com/msarahan) URL: #6780
rapids-bot bot
pushed a commit
that referenced
this pull request
Jun 12, 2025
This #2679 introduced breaking changes in RAFT APIs but missed 1 place which broke cuGraph. cc @ChuckHastings @jnke2016 Authors: - Divye Gala (https://github.com/divyegala) Approvers: - Chuck Hastings (https://github.com/ChuckHastings) - Joseph Nke (https://github.com/jnke2016) URL: #2704
bkarsin
pushed a commit
to bkarsin/cuvs
that referenced
this pull request
Jun 19, 2025
Depends on rapidsai/raft#2679 with reference issue rapidsai/raft#2681. This PR reduces the wheel size from 936.9 MB to 917.1 MB. Authors: - Divye Gala (https://github.com/divyegala) - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Robert Maynard (https://github.com/robertmaynard) - Corey J. Nolet (https://github.com/cjnolet) - Mike Sarahan (https://github.com/msarahan) - https://github.com/jakirkham URL: rapidsai#925
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2681