Skip to content

Lanczos Solver which=SA,SM,LA,LM argument #2628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 56 commits into from
Jun 16, 2025
Merged

Lanczos Solver which=SA,SM,LA,LM argument #2628

merged 56 commits into from
Jun 16, 2025

Conversation

aamijar
Copy link
Member

@aamijar aamijar commented Apr 8, 2025 •
edited
Loading

Resolves #2624
Resolves #2483

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Apr 8, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@aamijar aamijar force-pushed the lanczos-solver-which-argument branch from 3585778 to 6327b2f Compare April 8, 2025 18:41
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Apr 8, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@aamijar aamijar added enhancement New feature or request non-breaking Non-breaking change improvement Improvement / enhancement to an existing function and removed enhancement New feature or request labels Apr 8, 2025
@aamijar aamijar marked this pull request as ready for review April 8, 2025 23:59
@aamijar aamijar requested review from a team as code owners April 8, 2025 23:59
lowener
lowener requested changes Apr 23, 2025
View reviewed changes
cjnolet
cjnolet reviewed May 15, 2025
View reviewed changes
@aamijar aamijar changed the base branch from branch-25.06 to branch-25.08 May 29, 2025 08:44
@aamijar aamijar force-pushed the lanczos-solver-which-argument branch from ce3b63d to 3cd8f21 Compare May 31, 2025 00:10
@aamijar
Copy link
Member Author

aamijar commented Jun 3, 2025

Hi @cjnolet, I'm running into some issues with tests not passing when using solver with SM. Spectral embedding only needs LA, so in the interest of getting that in, can we follow up with SM in a separate PR?

@divyegala divyegala self-requested a review June 16, 2025 20:00
divyegala
divyegala approved these changes Jun 16, 2025
View reviewed changes
Copy link
Member

@divyegala divyegala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create a follow-up issue for addressing SM failures and add it as a sub-issue to the overarching tracker issue?

@aamijar aamijar mentioned this pull request Jun 16, 2025
Open
@aamijar
Copy link
Member Author

aamijar commented Jun 16, 2025

Can you create a follow-up issue for addressing SM failures and add it as a sub-issue to the overarching tracker issue?

done!

@divyegala
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 8bf7057 into rapidsai:branch-25.08 Jun 16, 2025
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet left review comments

@lowener lowener lowener approved these changes

@divyegala divyegala divyegala approved these changes

Assignees

@aamijar aamijar

Labels
cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
Vector Search, ML, & Data Mining Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] pylibraft eigsh and lanczos solver needs which={'LA', 'LM', 'SM', 'SA'} [FEA] Add largest eigenvalues computation to Lanczos
4 participants
@aamijar @divyegala @cjnolet @lowener