Merge pull request #20257 from cgranleese-r7/fixes-deprecation-error

Fixes an error in `report_note` deprecation message

Author: dwelch-r7

lib/msf/core/db_manager/note.rb

@@ -145,9 +145,10 @@ def report_note(opts)
     ntype  = opts.delete(:type) || opts.delete(:ntype) || (raise RuntimeError, "A note :type or :ntype is required")
 
     unless opts[:data].is_a?(Hash)
-      message = "[DEPRECATION] Using #{method.inspect} with a non-hash data value is deprecated, please raise a Github issue with this output. Called from: #{caller(1, stack_size).to_a}"
-      print_warning message
-      # Additionally write to ~/.msf4/logs/framework.log - as this gets attached to Github issues etc
+      stack_trace = caller.map { |line| "[-]   #{line}" }.join("\n")
+      message = "\n[-] [DEPRECATION] Using #{__method__} with a non-hash data value is deprecated, please raise a Github issue with this output.\n[-] Call stack:\n#{stack_trace}"
+      warn(message)
+      # Additionally write to ~/.msf4/logs/framework.log - as this gets attached to GitHub issues etc
       elog(message)
     end