Deprecate use_tidy_style()
#2138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
reviewed
Jul 11, 2025
| #' @export | ||
| #' @rdname tidy-deprecated | ||
| use_tidy_style <- function(strict = TRUE) { | ||
| lifecycle::deprecate_warn( |
There was a problem hiding this comment.
Suggested change
| lifecycle::deprecate_warn( | |
| lifecycle::deprecate_stop( |
There was a problem hiding this comment.
Hmm. In theory I'm on board with deprecate_stop(). But it felt like going from 0 to 60.
If anyone's got use_tidy_style() in teaching materials or personal workflow scripts or similar, it feels like an error versus warning might make a big difference. I went with deprecate_warning() since it feels like a state we should pass through.
Do you feel strongly that we go straight to deprecate_stop()?
There was a problem hiding this comment.
Based on a GitHub search, I do think we should at least pass through a deprecate_warn() phase.
hadley
approved these changes
Jul 11, 2025
DavisVaughan
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2110