Skip to content

Commit 3bef4d8

Browse files
committed
Re-run revdeps; revise cran-comments
1 parent 45b65ff commit 3bef4d8

File tree

2 files changed

+13
-4
lines changed

2 files changed

+13
-4
lines changed

cran-comments.md

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
1-
## Special note
1+
This patch release 2.1.3 modifies a test to ensure that intermittent GitHub rate limiting cannot lead to ungraceful failure on CRAN.
22

3-
In case it comes up, the reverse dependency tidytuesdayR regularly fails when CRAN checks usethis, due to tidytuesdayR hitting a GitHub API rate limit in its tests. This is an expected false positive (we've seen it more than once now) and has nothing to do with usethis.
3+
This submission, on 2021-10-25, is in direct response to an email from Professor Brian Ripley, also received on 2021-10-25, which states:
4+
5+
"Please correct before 2021-11-08 to safely retain your package on CRAN."
6+
7+
In case it comes up, the reverse dependency tidytuesdayR regularly fails when CRAN checks usethis, due to tidytuesdayR hitting a GitHub API rate limit in its tests. This is an expected false positive and has been seen on multiple previous successful usethis submissions.
8+
9+
Although that is the same phenomenon that I've just addressed in a usethis test, this is a coincidence. That is, the tidytuesdayR test failure due to GitHub rate limits is completely independent of that package's usage of usethis. Those GitHub calls are not routing through any usethis functions. The fragile tests were present before the recent usethis release and there's nothing I can do in usethis to fix the behaviour of their tests.
410

511
## R CMD check results
612

@@ -10,7 +16,9 @@ The note is "Days since last update: 2" (see above).
1016

1117
## revdepcheck results
1218

13-
We checked 120 reverse dependencies (119 from CRAN + 1 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package.
19+
## revdepcheck results
20+
21+
We checked 124 reverse dependencies (123 from CRAN + 1 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package.
1422

1523
* We saw 0 new problems
1624
* We failed to check 1 packages
@@ -20,3 +28,4 @@ Issues with CRAN packages are summarised below.
2028
### Failed to check
2129

2230
* butcher (NA)
31+

revdep/cran.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
## revdepcheck results
22

3-
We checked 121 reverse dependencies (120 from CRAN + 1 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package.
3+
We checked 124 reverse dependencies (123 from CRAN + 1 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package.
44

55
* We saw 0 new problems
66
* We failed to check 1 packages

0 commit comments

Comments
 (0)