WIN32 (Visual Studio and Mingw64/MSYS2) compatible code

[coreyapowell]

Greetings team.
I didn't know how else to communicate with your group. Years ago I needed to do some JS embedding and both Node.js and QuickJS were not compiling in my environments. Recently I found that not only is Bellard's version compiling in Ming32, I found your project! Today my needs are requiring command line scripting. So I have taken the liberty of filling in some of the missing functionality in WIN32. This is mainly the kind of thing I need for my job when Windows Scripting Host cannot dare. I was hoping I could work with your team and help fill in the gaps, as what I mostly need is something I can directly download and compile like this.

I've tested the attached test script in Ming64 on MSYS2, WSL running Debian, and Visual Studio 2022. I've attached the files for review, adding support for the following:
js_os_symlink - now includes _WIN32. note you cannot use readlink
js_os_pipe - now includes _WIN32 (using fds not handles)
js_os_exec - now includes _WIN32
-build_ms_envp - _WIN32 only ( one large double-nulled string, no array )
js_watchpid - linux and _WIN32, hybrid function to do the wait, no status
js_os_kill - now includes _WIN32 (just a kill on pid, no signals)
js_std_tmpfile new _MING version. permissions fail these days.
-JSSTDFile - holds filename for deletion
-std file finalizer - added remove tmpfile on delete

test_std.js.txt

quickjs-libc.c.txt

[bnoordhuis]

Can you submit your changes as pull requests, one change per request? Thanks.

[coreyapowell]

I could separate the changes into files but there's 400 lines in the qjs:os module, all to support the missing test_os_exec() in windows. Otherwise you can't effectively test it, you need pipes and waitpid and kill to test any of it. Also without exec you can't test kill and watchpid. They sort of go together as one change.
I could separate the tmpfile problem but I'm thinking the group just wasn't aware that tmpfile is broken in windows indefinitely.
I could separate symlink .. but these are trivial in comparison to exec and it's windows-only code. It was just to satisfy test_std, I can remove them.
I've never worked outside of a corporation with github and it's been about 12 years, but I guess you meant make a fork? I made a fork. I've never done it this way, sorry.
https://github.com/coreyapowell/quickjs/pull/1

[bnoordhuis]

You made the pull request to your own fork, we can't review or merge it that way. Make it to this repository.

[coreyapowell]

uhm ... you're more experienced than I am, but I'm not a member of the project group. All my buttons were disabled except the option to create an issue. This was honestly the only option I could find. I've been reading github help for at least 2 hours and it says that I don't have access. It says that the normal policy is to create my own fork and submit files that way. I also thought it was odd to create a fork, but I can't create a pull request in your group, and that's what github seems to think.
I hate to be a complete noob, but can you verify that I can do what you're saying? Otherwise, that's why I announced and requested you add me to the group.

[bnoordhuis]

The way it works is this: you push your code to a branch, let's call it example, then you visit https://github.com/coreyapowell/quickjs/pull/new/example and that lets you open a pull request against this repo.

[coreyapowell]

I named the pull request : https://github.com/coreyapowell/quickjs/tree/test_std-win-patch-1
Github named the branch itself. I copied this link : https://github.com/coreyapowell/quickjs/pull/1

I don't have any other options on my end. I'm thinking as an outside party, I cannot do anything to your project except submit an Issue or Fork the repository. As you can see, the Branch screen has no options:

[sdegutis]

@coreyapowell when you submit the pull request, switch around the to/from repos. Sent it from your repo, to this repo.