Do not require a default datasource definition if TenantConnectionResolver is implemented

[alexkolson]

Description

Hi there,

Would it be possible / an okay idea to not require a default datasource definition if multi-tenancy / programmatic datasource configuration is used? I'm not sure how at all this would be implemented, but from a developer experience point-of-view, this would be nice. No having to define extra non-used properties in application.properties just to avoid errors when the application tries to start.

Implementation ideas

Perhaps a sort of escape hatch, where if an implementation of TenantConnectionResolver is detected in the CDI container, a message is logged letting the developer know that they are now on their own for validating their configuration and that quarkus will not check to make sure a datasource is configured before starting.

[gsmet]

Which errors do you get exactly? Could you share a small Maven project showing the problem you have?

Thanks!

[quarkus-bot]

/cc @DavideD, @Sanne, @gavinking, @mswatosh, @yrodiere

[sberyozkin]

Not sure it is relevant, in quarkus-oidc we have a tenant-enabled property to disable the default properties (tenant), or other tenant if needed, so in a multi-tenant setup the users only do quarkus.oidc.tenant-enabled=false for OIDC to avoid dealing with the main/default properties. I'm thinking of making sure to have quarkus.oidc.tenant-enabled=false not be even necessary as OIDC will retry to reconnect at the first request time if the connection failed at the start up - which would fail again for the default tenant, but the tenant resolvers will be there to provide the right tenant config...

[alexkolson]

Hi @gsmet! Thank you for responding! Here is a reproducer for you, as requested.

@sberyozkin This definitely sounds related! Perhaps the multi-tenancy feature for hibernate could do something similar?

[svanschooten]

Any updates here? I am running into the same issue of needing a default datasource even when I specify I want to use multi-tenant mode. Also implemented the TenantConnectionResolver and TenantResolver so those should supply a proper connection right?