Skip to content

Commit 7fabab4

Browse files
authored
(6/n - non-xlformers conda-on-mast mvp)(torchx/runner) Create //torchx/runner:lib_core with no plugin bundling (#1083)
Summary: See details in [torchx-lite](https://docs.google.com/document/d/1Y_DzoRMAKhqbzE2LQDb7k3H5R-4PnkYdA9R4YLLFLk4/edit?tab=t.0#heading=h.unqedx38434n) doc. Creates a pure core library target for `torchx.runner` called `//torchx/runner:lib_core`. Similar to D77394064 which creates `//torchx/schedulers:lib_core` NOTE: I added a `autodeps_redirect` to `//torchx/runner:lib` from `:lib_core`. I've noticed that autodeps honors this in some cases but not in others (read IMPORTANT note below if you are finding that autodeps is removing `:lib` in favor of `:lib_core`) IMPORTANT: If you wind up here because autodeps is removing `//torchx/runner:lib` in favor of `//torchx/runner:lib_core`, you have two options (see below). OPTION 2 is preferred since you'll only pull in what you need (not the entire universe of plugins). OPTION 1. Add `# manual` tag to the existing `//torchx/runner:lib` ``` ... deps = [ "//torchx/runner:lib_core", # <-- autodeps will still add this (which is OK) "//torchx/runner:lib", # manual ... ] ... ``` OPTION 2: Accept the swap to `//torchx/runner:lib_core` and add any plugins that you need with `# manual` ``` ... deps = [ "//torchx/runner:lib_core", "//torchx/schedulers/fb:mast_scheduler", # manual (mast scheduler plugin) ... ] ... ``` Reviewed By: highker Differential Revision: D77400710
1 parent 2d59334 commit 7fabab4

File tree

0 file changed

+0
-0
lines changed

    0 file changed

    +0
    -0
    lines changed

    0 commit comments

    Comments
     (0)