Skip to content

Commit e7690e2

Browse files
PaulZhang12facebook-github-bot
authored andcommitted
Fix binary push release and update with CUDA 12.4 (#2501)
Summary: Pull Request resolved: #2501 Reviewed By: iamzainhuda Differential Revision: D64704414 fbshipit-source-id: a3a41d2614c262159a0850b0e0bf898c87a255f6
1 parent 4a20704 commit e7690e2

File tree

1 file changed

+15
-21
lines changed

1 file changed

+15
-21
lines changed

.github/workflows/release_build.yml

Lines changed: 15 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -18,37 +18,32 @@ jobs:
1818
strategy:
1919
matrix:
2020
include:
21-
- os: linux.2xlarge
22-
python-version: 3.8
23-
python-tag: "py38"
24-
cuda-tag: "cu121"
2521
- os: linux.2xlarge
2622
python-version: 3.9
2723
python-tag: "py39"
28-
cuda-tag: "cu121"
24+
cuda-tag: "cu124"
2925
- os: linux.2xlarge
3026
python-version: '3.10'
3127
python-tag: "py310"
32-
cuda-tag: "cu121"
28+
cuda-tag: "cu124"
3329
- os: linux.2xlarge
3430
python-version: '3.11'
3531
python-tag: "py311"
36-
cuda-tag: "cu121"
32+
cuda-tag: "cu124"
3733
- os: linux.2xlarge
3834
python-version: '3.12'
3935
python-tag: "py312"
40-
cuda-tag: "cu121"
36+
cuda-tag: "cu124"
4137
steps:
4238
# Checkout the repository to the GitHub Actions runner
4339
- name: Check ldd --version
4440
run: ldd --version
4541
- name: Checkout
46-
uses: actions/checkout@v2
42+
uses: actions/checkout@v4
4743
- name: Update pip
4844
run: |
4945
sudo yum update -y
5046
sudo yum -y install git python3-pip
51-
sudo pip3 install --upgrade pip
5247
- name: Setup conda
5348
run: |
5449
wget https://repo.anaconda.com/miniconda/Miniconda3-latest-Linux-x86_64.sh -O ~/miniconda.sh
@@ -73,12 +68,12 @@ jobs:
7368
- name: Install PyTorch and CUDA
7469
shell: bash
7570
run: |
76-
conda run -n build_binary pip install torch --index-url https://download.pytorch.org/whl/test/cu121
71+
conda run -n build_binary pip install torch
7772
- name: Install fbgemm
7873
shell: bash
7974
run: |
8075
conda run -n build_binary pip install numpy
81-
conda run -n build_binary pip install fbgemm-gpu --index-url https://download.pytorch.org/whl/test/cu121
76+
conda run -n build_binary pip install fbgemm-gpu
8277
- name: Install Dependencies
8378
shell: bash
8479
run: |
@@ -102,7 +97,7 @@ jobs:
10297
python setup.py bdist_wheel \
10398
--python-tag=${{ matrix.python-tag }}
10499
- name: Upload wheel as GHA artifact
105-
uses: actions/upload-artifact@v2
100+
uses: actions/upload-artifact@v4
106101
with:
107102
name: torchrec_${{ matrix.python-version }}_${{ matrix.cuda-tag }}.whl
108103
path: dist/torchrec-*.whl
@@ -112,9 +107,9 @@ jobs:
112107
runs-on: ${{ matrix.os }}
113108
strategy:
114109
matrix:
115-
os: [linux.4xlarge.nvidia.gpu]
116-
python-version: [3.8, 3.9, "3.10", "3.11", "3.12"]
117-
cuda-tag: ["cu121"]
110+
os: [linux.g5.12xlarge.nvidia.gpu]
111+
python-version: [3.9, "3.10", "3.11", "3.12"]
112+
cuda-tag: ["cu124"]
118113
needs: build_on_cpu
119114
# the glibc version should match the version of the one we used to build the binary
120115
# for this case, it's 2.26
@@ -149,12 +144,11 @@ jobs:
149144
sudo lshw -C display
150145
# Checkout the repository to the GitHub Actions runner
151146
- name: Checkout
152-
uses: actions/checkout@v2
147+
uses: actions/checkout@v4
153148
- name: Update pip
154149
run: |
155150
sudo yum update -y
156151
sudo yum -y install git python3-pip
157-
sudo pip3 install --upgrade pip
158152
- name: Setup conda
159153
run: |
160154
wget https://repo.anaconda.com/miniconda/Miniconda3-latest-Linux-x86_64.sh -O ~/miniconda.sh
@@ -179,19 +173,19 @@ jobs:
179173
- name: Install PyTorch and CUDA
180174
shell: bash
181175
run: |
182-
conda run -n build_binary pip install torch --index-url https://download.pytorch.org/whl/test/cu121
176+
conda run -n build_binary pip install torch
183177
# download wheel from GHA
184178
- name: Install fbgemm
185179
shell: bash
186180
run: |
187181
conda run -n build_binary pip install numpy
188-
conda run -n build_binary pip install fbgemm-gpu --index-url https://download.pytorch.org/whl/test/cu121
182+
conda run -n build_binary pip install fbgemm-gpu
189183
- name: Install torchmetrics
190184
shell: bash
191185
run: |
192186
conda run -n build_binary pip install torchmetrics==1.0.3
193187
- name: Download wheel
194-
uses: actions/download-artifact@v2
188+
uses: actions/download-artifact@v4
195189
with:
196190
name: torchrec_${{ matrix.python-version }}_${{ matrix.cuda-tag }}.whl
197191
- name: Display structure of downloaded files

0 commit comments

Comments
 (0)