Skip to content

Commit 44578d0

Browse files
aporialiaofacebook-github-bot
authored andcommitted
Enable Cuda 12.6 since FBGEMM offers it now (#2845)
Summary: Pull Request resolved: #2845 I believe this should resolve cu126 errors on nightly binaries as well. Before we filtered out CUDA version 12.6 because FBGEMM (torchrec dependency) did not support it yet, but now there is support - seen from https://download.pytorch.org/whl/nightly/cu126 with `fbgemm_gpu` available - so we should remove our filter. Our filter was causing issue with CU126 nightly binaries because there is no torchrec version supported. {F1976345189} Reviewed By: aliafzal Differential Revision: D71707060 fbshipit-source-id: 70877d6d46e749203d3f11f72973f38fa8b32f16
1 parent 07bf2c1 commit 44578d0

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

.github/scripts/filter.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@
1111

1212
def main():
1313
"""
14-
Since FBGEMM doesn't publish CUDA 12.6 binaries yet, torchrec will not work with
15-
CUDA 12.6. As a result, we filter out CUDA 12.6 from the build matrix that
16-
determines with nightly builds are run.
14+
For filtering out certain cuda versions in the build matrix that
15+
determines with nightly builds are run. This ensures TorchRec is
16+
always consistent in version compatibility with FBGEMM.
1717
"""
1818

1919
full_matrix_string = os.environ["MAT"]
@@ -22,8 +22,7 @@ def main():
2222
new_matrix_entries = []
2323

2424
for entry in full_matrix["include"]:
25-
if entry["gpu_arch_version"] != "12.6":
26-
new_matrix_entries.append(entry)
25+
new_matrix_entries.append(entry)
2726

2827
new_matrix = {"include": new_matrix_entries}
2928
print(json.dumps(new_matrix))

0 commit comments

Comments
 (0)