Drop 3.8 CI and add 3.12 (#2296)

Summary: Pull Request resolved: #2296

Reviewed By: dstaay-fb, gnahzg

Differential Revision: D61221869

fbshipit-source-id: 95d87098dea6c8cdf67cd3202b4946c73c2f32ab

Author: PaulZhang12

.github/workflows/unittest_ci_cpu.yml

@@ -23,9 +23,6 @@ jobs:
         fail-fast: false
         matrix:
           include:
-            - os: linux.2xlarge
-              python-version: 3.8
-              python-tag: "py38"
             - os: linux.2xlarge
               python-version: 3.9
               python-tag: "py39"
@@ -35,6 +32,9 @@ jobs:
             - os: linux.2xlarge
               python-version: '3.11'
               python-tag: "py311"
+            - os: linux.2xlarge
+              python-version: '3.12'
+              python-tag: "py312"
     uses: pytorch/test-infra/.github/workflows/linux_job.yml@main
     with:
       runner: ${{ matrix.os }}

torchrec/metrics/tests/test_tower_qps.py

@@ -257,11 +257,11 @@ def test_warmup_checkpointing(self) -> None:
                     labels={"DefaultTask": model_output["label"]},
                     weights={"DefaultTask": model_output["weight"]},
                 )
-            self.assertEquals(
+            self.assertEqual(
                 qps._metrics_computations[0].warmup_examples,
                 batch_size * warmup_steps * (i + 1),
             )
-            self.assertEquals(
+            self.assertEqual(
                 qps._metrics_computations[0].num_examples,
                 batch_size * (warmup_steps + extra_steps) * (i + 1),
             )
@@ -303,9 +303,9 @@ def test_mtml_empty_update(self) -> None:
             else:
                 del labels["t2"]
             qps.update(predictions=predictions, labels=labels, weights=weights)
-            self.assertEquals(
+            self.assertEqual(
                 qps._metrics_computations[0].num_examples, (step + 1) // 2 * batch_size
             )
-            self.assertEquals(
+            self.assertEqual(
                 qps._metrics_computations[1].num_examples, (step + 2) // 2 * batch_size
             )

torchrec/modules/tests/test_embedding_modules.py

@@ -349,7 +349,7 @@ def test_device(self) -> None:
             tables=[config],
             device=torch.device("meta"),
         )
-        self.assertEquals(torch.device("meta"), ec.embeddings["t1"].weight.device)
+        self.assertEqual(torch.device("meta"), ec.embeddings["t1"].weight.device)
 
     def test_duplicate_config_name_fails(self) -> None:
         e1_config = EmbeddingConfig(