Skip to content

Change Enable KleidiAI to default in CMake #12452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 15, 2025
Merged

Change Enable KleidiAI to default in CMake #12452

merged 5 commits into from
Jul 15, 2025

Conversation

mcr229
Copy link
Contributor

@mcr229 mcr229 commented Jul 14, 2025 •
edited
Loading

No description provided.

@mcr229
Update
2ee6b60 
[ghstack-poisoned]
@mcr229
Copy link
Contributor Author

mcr229 commented Jul 14, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 14, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12452

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 4f4b570 with merge base a8070ec (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 14, 2025
@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

mcr229 added a commit that referenced this pull request Jul 14, 2025
@mcr229
Change Enable KleidiAI to default in CMake
44d0f8a 
ghstack-source-id: 559b7a7
ghstack-comment-id: 3070613382
Pull Request resolved: #12452
@mcr229
Update
21f1c17 
[ghstack-poisoned]
mcr229 added a commit that referenced this pull request Jul 14, 2025
@mcr229
Change Enable KleidiAI to default in CMake
ec893ef 
ghstack-source-id: cd10ca2
ghstack-comment-id: 3070613382
Pull Request resolved: #12452
mcr229 added a commit that referenced this pull request Jul 14, 2025
@mcr229
Change Enable KleidiAI to default in CMake
1f1b864 
ghstack-source-id: cd10ca2
ghstack-comment-id: 3070613382
Pull Request resolved: #12452
@mcr229
Update
08ba626 
[ghstack-poisoned]
@mcr229 mcr229 requested a review from digantdesai as a code owner July 14, 2025 21:54
mcr229 added a commit that referenced this pull request Jul 14, 2025
@mcr229
Change Enable KleidiAI to default in CMake
7306197 
ghstack-source-id: c75e15d
ghstack-comment-id: 3070613382
Pull Request resolved: #12452
digantdesai
digantdesai approved these changes Jul 15, 2025
View reviewed changes
Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Max.

digantdesai
digantdesai reviewed Jul 15, 2025
View reviewed changes
Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's pull in Packing changes in XNNPACK --> ET, or at least create an issue to track that.

@mcr229
Update
0aa7987 
[ghstack-poisoned]
mcr229 added a commit that referenced this pull request Jul 15, 2025
@mcr229
Change Enable KleidiAI to default in CMake
536f959 
ghstack-source-id: dbd5403
ghstack-comment-id: 3070613382
Pull Request resolved: #12452
@mcr229
Update
4f4b570 
[ghstack-poisoned]
mcr229 added a commit that referenced this pull request Jul 15, 2025
@mcr229
Change Enable KleidiAI to default in CMake
1bb29c1 
ghstack-source-id: 7fedac6
ghstack-comment-id: 3070613382
Pull Request resolved: #12452
@mcr229 mcr229 merged commit 54813d9 into main Jul 15, 2025
97 of 98 checks passed
@mcr229 mcr229 deleted the gh/mcr229/39/head branch July 15, 2025 20:04
@mcr229
Copy link
Contributor Author

mcr229 commented Jul 15, 2025

@pytorchbot cherry-pick --onto release/0.7 -c fixnewfeature

pytorchbot pushed a commit that referenced this pull request Jul 15, 2025
@mcr229 @pytorchbot
Change Enable KleidiAI to default in CMake (#12452)
e37359d 
(cherry picked from commit 54813d9)
@pytorchbot pytorchbot mentioned this pull request Jul 15, 2025
Open
@pytorchbot
Copy link
Collaborator

Cherry picking #12452

The cherry pick PR is at #12511 and it is recommended to link a fixnewfeature cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

lucylq pushed a commit that referenced this pull request Jul 17, 2025
@mcr229 @lucylq
Change Enable KleidiAI to default in CMake (#12452)
39313f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digantdesai digantdesai digantdesai approved these changes

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@kirklandsign kirklandsign Awaiting requested review from kirklandsign kirklandsign is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mcr229 @pytorchbot @digantdesai @facebook-github-bot