-
Notifications
You must be signed in to change notification settings - Fork 622
Refactor Memory Allocator from Arm Executor Runner #12353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Memory Allocator from Arm Executor Runner #12353
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12353
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 4 Unrelated FailuresAs of commit 579f693 with merge base f909aaa ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchbot label "release notes: none" |
c6bf143
to
ff8b2b5
Compare
Nice work, good idea to split it out so it can be usefull for more runners. We will probably have a few runner examples going forward. For examples for different OS/targets and I think we could do a better splitup between testing / semihosting and a "minimal" good example, as it's now much of the #ifdef stuff gets in the way if a good readable example. |
…e for other arm applications, e.g. zephyr
ff8b2b5
to
579f693
Compare
Summary
Some applications desire using more minimal memory allocators when leveraging the existing the exist arm_executor_runner.cpp, e.g. here. This change decouples a custom memory allocator wrapper from the executor runner so that apps can choose different implementations as needed.
Test plan
Ran the steps of the Arm EthosU tutorial to ensure that existing flow still works. I.e. running:
still produces the following output: