Skip to content

Commit b05d0e5

Browse files
committed
Enable dtype selective build if not fbcode for jarvis
^ Differential Revision: [D75256223](https://our.internmc.facebook.com/intern/diff/D75256223/) ghstack-source-id: 285772294 Pull Request resolved: #11090
1 parent e56fafb commit b05d0e5

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

examples/selective_build/targets.bzl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ def define_common_targets():
6565
deps = [
6666
":select_ops_in_dict",
6767
],
68-
dtype_selective_build = True,
68+
dtype_selective_build = is_xplat(),
6969
visibility = ["//executorch/..."],
7070
)
7171

@@ -78,7 +78,7 @@ def define_common_targets():
7878
deps = [
7979
":select_ops_in_dict",
8080
],
81-
dtype_selective_build = True,
81+
dtype_selective_build = is_xplat(),
8282
visibility = ["//executorch/..."],
8383
)
8484

shim_et/xplat/executorch/codegen/codegen.bzl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -644,8 +644,7 @@ def executorch_generated_lib(
644644

645645
if dtype_selective_build:
646646
if not expose_operator_symbols and not is_xplat():
647-
# TODO(T225169282): make this a fail once internal cases move to xplat.
648-
warning("""
647+
fail("""
649648
Dtype selective build with expose_operator_symbols=False works only in xplat -
650649
there are undefined symbols otherwise. Please try to use xplat, or talk to the
651650
executorch team. Setting expose_operator_symbols=True is not recommended as the

0 commit comments

Comments
 (0)