Skip to content

Commit 450d1f9

Browse files
authored
Removing uneeded buck deps in cmake build flow (#11315)
### Summary The buck and cmake build flows should be independent, where the cmake build flow should not rely on buck targets to be built or used. ### Test plan Tested on examples and tutorials, and no functional difference was seen between runs before and after change.
1 parent 3fe276e commit 450d1f9

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

.ci/scripts/utils.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,8 +158,7 @@ build_executorch_runner() {
158158
cmake_install_executorch_lib() {
159159
echo "Installing libexecutorch.a and libportable_kernels.a"
160160
clean_executorch_install_folders
161-
retry cmake -DBUCK2="$BUCK" \
162-
-DCMAKE_INSTALL_PREFIX=cmake-out \
161+
retry cmake -DCMAKE_INSTALL_PREFIX=cmake-out \
163162
-DCMAKE_BUILD_TYPE=Release \
164163
-DPYTHON_EXECUTABLE="$PYTHON_EXECUTABLE" \
165164
-Bcmake-out .

examples/selective_build/test_selective_build.sh

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,7 @@ test_cmake_select_all_ops() {
9292
local example_dir=examples/selective_build
9393
local build_dir=cmake-out/${example_dir}
9494
rm -rf ${build_dir}
95-
retry cmake -DBUCK2="$BUCK" \
96-
-DCMAKE_BUILD_TYPE=Release \
95+
retry cmake -DCMAKE_BUILD_TYPE=Release \
9796
-DEXECUTORCH_SELECT_ALL_OPS=ON \
9897
-DCMAKE_INSTALL_PREFIX=cmake-out \
9998
-DPYTHON_EXECUTABLE="$PYTHON_EXECUTABLE" \
@@ -118,8 +117,7 @@ test_cmake_select_ops_in_list() {
118117
local build_dir=cmake-out/${example_dir}
119118
# set MAX_KERNEL_NUM=22: 19 primops, add, mul
120119
rm -rf ${build_dir}
121-
retry cmake -DBUCK2="$BUCK" \
122-
-DCMAKE_BUILD_TYPE=Release \
120+
retry cmake -DCMAKE_BUILD_TYPE=Release \
123121
-DMAX_KERNEL_NUM=22 \
124122
-DEXECUTORCH_SELECT_OPS_LIST="aten::convolution.out,\
125123
aten::_native_batch_norm_legit_no_training.out,aten::hardtanh.out,aten::add.out,\
@@ -146,8 +144,7 @@ test_cmake_select_ops_in_yaml() {
146144
local example_dir=examples/selective_build
147145
local build_dir=cmake-out/${example_dir}
148146
rm -rf ${build_dir}
149-
retry cmake -DBUCK2="$BUCK" \
150-
-DCMAKE_BUILD_TYPE=Release \
147+
retry cmake -DCMAKE_BUILD_TYPE=Release \
151148
-DEXECUTORCH_SELECT_OPS_YAML=ON \
152149
-DCMAKE_INSTALL_PREFIX=cmake-out \
153150
-DPYTHON_EXECUTABLE="$PYTHON_EXECUTABLE" \

0 commit comments

Comments
 (0)