Skip to content

Commit 1f697f0

Browse files
authored
Retire kernels_portable framework in favor of kernels_optimized (#11226)
1 parent 01d6441 commit 1f697f0

File tree

6 files changed

+2
-14
lines changed

6 files changed

+2
-14
lines changed

.Package.swift/kernels_portable/dummy.swift

Whitespace-only changes.

.Package.swift/kernels_portable_debug/dummy.swift

Whitespace-only changes.

.github/workflows/apple.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,6 @@ jobs:
154154
"backend_xnnpack"
155155
"kernels_custom"
156156
"kernels_optimized"
157-
"kernels_portable"
158157
"kernels_quantized"
159158
"threadpool"
160159
)

Package.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,6 @@ let products = deliverables([
7878
"threadpool",
7979
],
8080
],
81-
"kernels_portable": [:],
8281
"kernels_quantized": [:],
8382
])
8483

docs/source/using-executorch-ios.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,7 @@ The ExecuTorch Runtime for iOS and macOS is distributed as a collection of prebu
1111
* `backend_mps` - MPS backend
1212
* `backend_xnnpack` - XNNPACK backend
1313
* `kernels_custom` - Custom kernels for LLMs
14-
* `kernels_optimized` - Optimized kernels
15-
* `kernels_portable` - Portable kernels (naive implementation used as a reference)
14+
* `kernels_optimized` - Accelerated generic CPU kernels
1615
* `kernels_quantized` - Quantized kernels
1716

1817
Link your binary with the ExecuTorch runtime and any backends or kernels used by the exported ML model. It is recommended to link the core runtime to the components that use ExecuTorch directly, and link kernels and backends against the main app target.
@@ -66,7 +65,7 @@ let package = Package(
6665
dependencies: [
6766
.product(name: "executorch", package: "executorch"),
6867
.product(name: "backend_xnnpack", package: "executorch"),
69-
.product(name: "kernels_portable", package: "executorch"),
68+
.product(name: "kernels_optimized", package: "executorch"),
7069
// Add other backends and kernels as needed.
7170
]),
7271
]

scripts/build_apple_frameworks.sh

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -65,11 +65,6 @@ liboptimized_native_cpu_ops_lib.a,\
6565
libportable_kernels.a,\
6666
:"
6767

68-
FRAMEWORK_KERNELS_PORTABLE="kernels_portable:\
69-
libportable_kernels.a,\
70-
libportable_ops_lib.a,\
71-
:"
72-
7368
FRAMEWORK_KERNELS_QUANTIZED="kernels_quantized:\
7469
libquantized_kernels.a,\
7570
libquantized_ops_lib.a,\
@@ -86,7 +81,6 @@ usage() {
8681
echo " --custom Only build the Custom kernels."
8782
echo " --mps Only build the Metal Performance Shaders backend."
8883
echo " --optimized Only build the Optimized kernels."
89-
echo " --portable Only build the Portable kernels."
9084
echo " --quantized Only build the Quantized kernels."
9185
echo " --xnnpack Only build the XNNPACK backend."
9286
echo
@@ -104,7 +98,6 @@ set_cmake_options_override() {
10498
"-DEXECUTORCH_BUILD_KERNELS_CUSTOM=OFF"
10599
"-DEXECUTORCH_BUILD_MPS=OFF"
106100
"-DEXECUTORCH_BUILD_KERNELS_OPTIMIZED=OFF"
107-
"-DEXECUTORCH_BUILD_PORTABLE_OPS=OFF"
108101
"-DEXECUTORCH_BUILD_KERNELS_QUANTIZED=OFF"
109102
"-DEXECUTORCH_BUILD_XNNPACK=OFF"
110103
)
@@ -135,7 +128,6 @@ for arg in "$@"; do
135128
--custom) set_cmake_options_override "EXECUTORCH_BUILD_KERNELS_CUSTOM" ;;
136129
--mps) set_cmake_options_override "EXECUTORCH_BUILD_MPS" ;;
137130
--optimized) set_cmake_options_override "EXECUTORCH_BUILD_KERNELS_OPTIMIZED" ;;
138-
--portable) set_cmake_options_override "EXECUTORCH_BUILD_PORTABLE_OPS" ;;
139131
--quantized) set_cmake_options_override "EXECUTORCH_BUILD_KERNELS_QUANTIZED" ;;
140132
--xnnpack) set_cmake_options_override "EXECUTORCH_BUILD_XNNPACK" ;;
141133
*)
@@ -240,7 +232,6 @@ for mode in "${MODES[@]}"; do
240232
append_framework_flag "EXECUTORCH_BUILD_XNNPACK" "$FRAMEWORK_BACKEND_XNNPACK" "$mode"
241233
append_framework_flag "EXECUTORCH_BUILD_KERNELS_CUSTOM" "$FRAMEWORK_KERNELS_CUSTOM" "$mode"
242234
append_framework_flag "EXECUTORCH_BUILD_KERNELS_OPTIMIZED" "$FRAMEWORK_KERNELS_OPTIMIZED" "$mode"
243-
append_framework_flag "EXECUTORCH_BUILD_PORTABLE_OPS" "$FRAMEWORK_KERNELS_PORTABLE" "$mode"
244235
append_framework_flag "EXECUTORCH_BUILD_KERNELS_QUANTIZED" "$FRAMEWORK_KERNELS_QUANTIZED" "$mode"
245236

246237
cd "${OUTPUT_DIR}"

0 commit comments

Comments
 (0)